Update supported-configurations to be consistent with Feature Parity Dashboard#9703
Update supported-configurations to be consistent with Feature Parity Dashboard#9703
supported-configurations to be consistent with Feature Parity Dashboard#9703Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
sarahchen6
left a comment
There was a problem hiding this comment.
just to confirm -- the "B" label means that the configuration is shared with other tracers so has different aliases?
are the labels possibly documented somewhere? if not maybe a comment could be helpful
No, labels are typically auto-generated when a new configuration is added to the FPD. (Essentially just in alphabetical order). So if I add a config that doesn't exist, it would be given a version of A and if it already exists, a value of B, C, and so on. Note: This isn't something that devs will typically need to worry about, but rather needed to make the initial state valid. JSON also doesn't support comments 😞 but I'll think of where this makes sense to document! |
|
Ohh interesting okay thanks for the clarification! |
|
🎯 Code Coverage 🔗 Commit SHA: 38ceec6 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017285
Total [baseline] (10.642 s) : 0, 10642130
Agent [candidate] (1.017 s) : 0, 1017197
Total [candidate] (10.868 s) : 0, 10868172
section appsec
Agent [baseline] (1.193 s) : 0, 1193408
Total [baseline] (11.12 s) : 0, 11119980
Agent [candidate] (1.195 s) : 0, 1194949
Total [candidate] (11.066 s) : 0, 11066354
section iast
Agent [baseline] (1.15 s) : 0, 1150238
Total [baseline] (10.989 s) : 0, 10989456
Agent [candidate] (1.148 s) : 0, 1148331
Total [candidate] (11.035 s) : 0, 11034556
section profiling
Agent [baseline] (1.165 s) : 0, 1164509
Total [baseline] (11.123 s) : 0, 11122784
Agent [candidate] (1.16 s) : 0, 1159927
Total [candidate] (11.069 s) : 0, 11068761
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (693.832 ms) : 0, 693832
BytebuddyAgent [candidate] (693.863 ms) : 0, 693863
GlobalTracer [baseline] (241.755 ms) : 0, 241755
GlobalTracer [candidate] (241.965 ms) : 0, 241965
AppSec [baseline] (32.252 ms) : 0, 32252
AppSec [candidate] (32.144 ms) : 0, 32144
Debugger [baseline] (6.409 ms) : 0, 6409
Debugger [candidate] (6.4 ms) : 0, 6400
Remote Config [baseline] (701.195 µs) : 0, 701
Remote Config [candidate] (707.41 µs) : 0, 707
Telemetry [baseline] (9.343 ms) : 0, 9343
Telemetry [candidate] (9.337 ms) : 0, 9337
Flare Poller [baseline] (10.313 ms) : 0, 10313
Flare Poller [candidate] (10.135 ms) : 0, 10135
section appsec
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (717.093 ms) : 0, 717093
BytebuddyAgent [candidate] (718.455 ms) : 0, 718455
GlobalTracer [baseline] (234.087 ms) : 0, 234087
GlobalTracer [candidate] (234.496 ms) : 0, 234496
AppSec [baseline] (175.704 ms) : 0, 175704
AppSec [candidate] (175.384 ms) : 0, 175384
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.149 ms) : 0, 6149
Remote Config [baseline] (638.249 µs) : 0, 638
Remote Config [candidate] (630.892 µs) : 0, 631
Telemetry [baseline] (8.403 ms) : 0, 8403
Telemetry [candidate] (8.492 ms) : 0, 8492
Flare Poller [baseline] (3.926 ms) : 0, 3926
Flare Poller [candidate] (3.938 ms) : 0, 3938
IAST [baseline] (24.921 ms) : 0, 24921
IAST [candidate] (24.793 ms) : 0, 24793
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (814.27 ms) : 0, 814270
BytebuddyAgent [candidate] (813.105 ms) : 0, 813105
GlobalTracer [baseline] (231.82 ms) : 0, 231820
GlobalTracer [candidate] (231.25 ms) : 0, 231250
AppSec [baseline] (35.141 ms) : 0, 35141
AppSec [candidate] (35.296 ms) : 0, 35296
Debugger [baseline] (6.203 ms) : 0, 6203
Debugger [candidate] (6.089 ms) : 0, 6089
Remote Config [baseline] (611.605 µs) : 0, 612
Remote Config [candidate] (605.229 µs) : 0, 605
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.612 ms) : 0, 8612
Flare Poller [baseline] (4.219 ms) : 0, 4219
Flare Poller [candidate] (4.15 ms) : 0, 4150
IAST [baseline] (26.5 ms) : 0, 26500
IAST [candidate] (26.413 ms) : 0, 26413
section profiling
ProfilingAgent [baseline] (107.776 ms) : 0, 107776
ProfilingAgent [candidate] (107.5 ms) : 0, 107500
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (722.571 ms) : 0, 722571
BytebuddyAgent [candidate] (720.075 ms) : 0, 720075
GlobalTracer [baseline] (218.973 ms) : 0, 218973
GlobalTracer [candidate] (217.365 ms) : 0, 217365
AppSec [baseline] (32.717 ms) : 0, 32717
AppSec [candidate] (32.648 ms) : 0, 32648
Debugger [baseline] (6.443 ms) : 0, 6443
Debugger [candidate] (7.196 ms) : 0, 7196
Remote Config [baseline] (702.74 µs) : 0, 703
Remote Config [candidate] (704.449 µs) : 0, 704
Telemetry [baseline] (15.093 ms) : 0, 15093
Telemetry [candidate] (15.85 ms) : 0, 15850
Flare Poller [baseline] (5.751 ms) : 0, 5751
Flare Poller [candidate] (4.135 ms) : 0, 4135
Profiling [baseline] (108.757 ms) : 0, 108757
Profiling [candidate] (108.629 ms) : 0, 108629
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023072
Total [baseline] (8.689 s) : 0, 8689288
Agent [candidate] (1.017 s) : 0, 1017074
Total [candidate] (8.672 s) : 0, 8671521
section iast
Agent [baseline] (1.149 s) : 0, 1149152
Total [baseline] (9.324 s) : 0, 9324097
Agent [candidate] (1.15 s) : 0, 1149996
Total [candidate] (9.29 s) : 0, 9289988
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (696.871 ms) : 0, 696871
BytebuddyAgent [candidate] (693.166 ms) : 0, 693166
GlobalTracer [baseline] (243.11 ms) : 0, 243110
GlobalTracer [candidate] (241.704 ms) : 0, 241704
AppSec [baseline] (32.513 ms) : 0, 32513
AppSec [candidate] (32.208 ms) : 0, 32208
Debugger [baseline] (6.462 ms) : 0, 6462
Debugger [candidate] (6.376 ms) : 0, 6376
Remote Config [baseline] (701.141 µs) : 0, 701
Remote Config [candidate] (711.975 µs) : 0, 712
Telemetry [baseline] (9.345 ms) : 0, 9345
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (11.349 ms) : 0, 11349
Flare Poller [candidate] (11.022 ms) : 0, 11022
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (814.091 ms) : 0, 814091
BytebuddyAgent [candidate] (814.159 ms) : 0, 814159
GlobalTracer [baseline] (231.288 ms) : 0, 231288
GlobalTracer [candidate] (231.781 ms) : 0, 231781
AppSec [baseline] (34.985 ms) : 0, 34985
AppSec [candidate] (35.3 ms) : 0, 35300
Debugger [baseline] (6.124 ms) : 0, 6124
Debugger [candidate] (6.107 ms) : 0, 6107
Remote Config [baseline] (613.287 µs) : 0, 613
Remote Config [candidate] (602.831 µs) : 0, 603
Telemetry [baseline] (8.612 ms) : 0, 8612
Telemetry [candidate] (8.508 ms) : 0, 8508
Flare Poller [baseline] (4.27 ms) : 0, 4270
Flare Poller [candidate] (4.22 ms) : 0, 4220
IAST [baseline] (26.414 ms) : 0, 26414
IAST [candidate] (26.611 ms) : 0, 26611
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 3 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (37.708 ms) : 37403, 38014
. : milestone, 37708,
appsec (48.77 ms) : 48342, 49198
. : milestone, 48770,
code_origins (45.594 ms) : 45197, 45992
. : milestone, 45594,
iast (46.827 ms) : 46407, 47247
. : milestone, 46827,
profiling (46.323 ms) : 45928, 46717
. : milestone, 46323,
tracing (44.37 ms) : 43987, 44754
. : milestone, 44370,
section candidate
no_agent (36.505 ms) : 36208, 36803
. : milestone, 36505,
appsec (48.882 ms) : 48456, 49308
. : milestone, 48882,
code_origins (42.88 ms) : 42512, 43247
. : milestone, 42880,
iast (44.978 ms) : 44588, 45369
. : milestone, 44978,
profiling (48.687 ms) : 48218, 49155
. : milestone, 48687,
tracing (45.757 ms) : 45341, 46174
. : milestone, 45757,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (4.321 ms) : 4269, 4372
. : milestone, 4321,
iast (9.954 ms) : 9788, 10120
. : milestone, 9954,
iast_FULL (14.07 ms) : 13788, 14353
. : milestone, 14070,
iast_GLOBAL (11.163 ms) : 10963, 11363
. : milestone, 11163,
profiling (8.662 ms) : 8526, 8798
. : milestone, 8662,
tracing (8.144 ms) : 8021, 8266
. : milestone, 8144,
section candidate
no_agent (4.239 ms) : 4188, 4289
. : milestone, 4239,
iast (9.377 ms) : 9224, 9530
. : milestone, 9377,
iast_FULL (14.79 ms) : 14494, 15085
. : milestone, 14790,
iast_GLOBAL (10.77 ms) : 10578, 10963
. : milestone, 10770,
profiling (8.876 ms) : 8739, 9013
. : milestone, 8876,
tracing (7.966 ms) : 7846, 8086
. : milestone, 7966,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
appsec (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
iast (18.568 s) : 18568000, 18568000
. : milestone, 18568000,
iast_GLOBAL (18.355 s) : 18355000, 18355000
. : milestone, 18355000,
profiling (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
tracing (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
section candidate
no_agent (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (18.746 s) : 18746000, 18746000
. : milestone, 18746000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
tracing (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~38ceec6d21, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.672 ms) : 3457, 3886
. : milestone, 3672,
iast (2.214 ms) : 2150, 2277
. : milestone, 2214,
iast_GLOBAL (2.259 ms) : 2195, 2323
. : milestone, 2259,
profiling (2.051 ms) : 2000, 2102
. : milestone, 2051,
tracing (2.019 ms) : 1970, 2069
. : milestone, 2019,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.502 ms) : 2449, 2556
. : milestone, 2502,
iast (2.21 ms) : 2146, 2273
. : milestone, 2210,
iast_GLOBAL (2.252 ms) : 2188, 2316
. : milestone, 2252,
profiling (2.048 ms) : 1997, 2099
. : milestone, 2048,
tracing (2.034 ms) : 1984, 2084
. : milestone, 2034,
|
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
- Probably make sense to add some docs into README.md that we have in
\metadatafolder? - Is it possible to cover with some tests? Like query by http some dasboard and compare JSONs? (Just generating ideas).
What tests are you imagining? We have a CI check in |
OK. |
What Does This Do
dd-trace-java has 31 configurations that are shared with other tracers, but have different aliases, and thus need to be mapped to a new "version". This PR updates the mapping of these configurations to be consistent with the Feature Parity Dashboard.
This PR also adds 1 config that was missing previously in the file.
Motivation
This needs to be done in order to consider
Config Inversionimplementation in Java as complete.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]