-
Notifications
You must be signed in to change notification settings - Fork 323
Increase Load benchmarks warmup time #9704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 1ab64de | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1030755
Total [baseline] (10.774 s) : 0, 10773577
Agent [candidate] (1.035 s) : 0, 1035121
Total [candidate] (10.842 s) : 0, 10842397
section appsec
Agent [baseline] (1.207 s) : 0, 1206811
Total [baseline] (10.984 s) : 0, 10983928
Agent [candidate] (1.204 s) : 0, 1204184
Total [candidate] (10.926 s) : 0, 10925967
section iast
Agent [baseline] (1.17 s) : 0, 1170171
Total [baseline] (11.112 s) : 0, 11112253
Agent [candidate] (1.159 s) : 0, 1159322
Total [candidate] (11.001 s) : 0, 11000625
section profiling
Agent [baseline] (1.179 s) : 0, 1178935
Total [baseline] (10.868 s) : 0, 10867680
Agent [candidate] (1.179 s) : 0, 1179295
Total [candidate] (10.934 s) : 0, 10933930
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (703.089 ms) : 0, 703089
BytebuddyAgent [candidate] (705.688 ms) : 0, 705688
GlobalTracer [baseline] (244.54 ms) : 0, 244540
GlobalTracer [candidate] (245.881 ms) : 0, 245881
AppSec [baseline] (32.24 ms) : 0, 32240
AppSec [candidate] (32.524 ms) : 0, 32524
Debugger [baseline] (6.435 ms) : 0, 6435
Debugger [candidate] (6.481 ms) : 0, 6481
Remote Config [baseline] (686.95 µs) : 0, 687
Remote Config [candidate] (689.49 µs) : 0, 689
Telemetry [baseline] (14.523 ms) : 0, 14523
Telemetry [candidate] (14.541 ms) : 0, 14541
Flare Poller [baseline] (6.484 ms) : 0, 6484
Flare Poller [candidate] (6.613 ms) : 0, 6613
section appsec
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (729.716 ms) : 0, 729716
BytebuddyAgent [candidate] (727.075 ms) : 0, 727075
GlobalTracer [baseline] (236.713 ms) : 0, 236713
GlobalTracer [candidate] (236.492 ms) : 0, 236492
AppSec [baseline] (173.817 ms) : 0, 173817
AppSec [candidate] (174.092 ms) : 0, 174092
Debugger [baseline] (5.903 ms) : 0, 5903
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (631.09 µs) : 0, 631
Remote Config [candidate] (628.716 µs) : 0, 629
Telemetry [baseline] (8.398 ms) : 0, 8398
Telemetry [candidate] (8.416 ms) : 0, 8416
Flare Poller [baseline] (3.942 ms) : 0, 3942
Flare Poller [candidate] (3.915 ms) : 0, 3915
IAST [baseline] (24.966 ms) : 0, 24966
IAST [candidate] (25.029 ms) : 0, 25029
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (829.906 ms) : 0, 829906
BytebuddyAgent [candidate] (822.388 ms) : 0, 822388
GlobalTracer [baseline] (234.903 ms) : 0, 234903
GlobalTracer [candidate] (233.349 ms) : 0, 233349
AppSec [baseline] (32.019 ms) : 0, 32019
AppSec [candidate] (29.775 ms) : 0, 29775
Debugger [baseline] (6.265 ms) : 0, 6265
Debugger [candidate] (6.138 ms) : 0, 6138
Remote Config [baseline] (621.195 µs) : 0, 621
Remote Config [candidate] (595.9 µs) : 0, 596
Telemetry [baseline] (8.785 ms) : 0, 8785
Telemetry [candidate] (8.432 ms) : 0, 8432
Flare Poller [baseline] (4.197 ms) : 0, 4197
Flare Poller [candidate] (4.079 ms) : 0, 4079
IAST [baseline] (30.499 ms) : 0, 30499
IAST [candidate] (31.855 ms) : 0, 31855
section profiling
ProfilingAgent [baseline] (110.13 ms) : 0, 110130
ProfilingAgent [candidate] (109.957 ms) : 0, 109957
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (730.438 ms) : 0, 730438
BytebuddyAgent [candidate] (730.907 ms) : 0, 730907
GlobalTracer [baseline] (221.234 ms) : 0, 221234
GlobalTracer [candidate] (221.428 ms) : 0, 221428
AppSec [baseline] (32.562 ms) : 0, 32562
AppSec [candidate] (33.132 ms) : 0, 33132
Debugger [baseline] (13.871 ms) : 0, 13871
Debugger [candidate] (12.795 ms) : 0, 12795
Remote Config [baseline] (706.601 µs) : 0, 707
Remote Config [candidate] (681.307 µs) : 0, 681
Telemetry [baseline] (8.998 ms) : 0, 8998
Telemetry [candidate] (8.977 ms) : 0, 8977
Flare Poller [baseline] (4.173 ms) : 0, 4173
Flare Poller [candidate] (4.166 ms) : 0, 4166
Profiling [baseline] (110.788 ms) : 0, 110788
Profiling [candidate] (110.58 ms) : 0, 110580
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039128
Total [baseline] (8.662 s) : 0, 8661887
Agent [candidate] (1.033 s) : 0, 1033001
Total [candidate] (8.672 s) : 0, 8671583
section iast
Agent [baseline] (1.17 s) : 0, 1169549
Total [baseline] (9.342 s) : 0, 9341986
Agent [candidate] (1.16 s) : 0, 1160280
Total [candidate] (9.322 s) : 0, 9322210
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.502 ms) : 0, 1502
BytebuddyAgent [baseline] (709.097 ms) : 0, 709097
BytebuddyAgent [candidate] (704.233 ms) : 0, 704233
GlobalTracer [baseline] (246.176 ms) : 0, 246176
GlobalTracer [candidate] (245.571 ms) : 0, 245571
AppSec [baseline] (32.794 ms) : 0, 32794
AppSec [candidate] (32.449 ms) : 0, 32449
Debugger [baseline] (6.486 ms) : 0, 6486
Debugger [candidate] (6.447 ms) : 0, 6447
Remote Config [baseline] (683.052 µs) : 0, 683
Remote Config [candidate] (671.61 µs) : 0, 672
Telemetry [baseline] (12.214 ms) : 0, 12214
Telemetry [candidate] (14.441 ms) : 0, 14441
Flare Poller [baseline] (8.803 ms) : 0, 8803
Flare Poller [candidate] (6.469 ms) : 0, 6469
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (830.136 ms) : 0, 830136
BytebuddyAgent [candidate] (822.455 ms) : 0, 822455
GlobalTracer [baseline] (235.058 ms) : 0, 235058
GlobalTracer [candidate] (233.926 ms) : 0, 233926
AppSec [baseline] (31.442 ms) : 0, 31442
AppSec [candidate] (29.894 ms) : 0, 29894
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.21 ms) : 0, 6210
Remote Config [baseline] (600.803 µs) : 0, 601
Remote Config [candidate] (612.388 µs) : 0, 612
Telemetry [baseline] (8.58 ms) : 0, 8580
Telemetry [candidate] (8.535 ms) : 0, 8535
Flare Poller [baseline] (4.189 ms) : 0, 4189
Flare Poller [candidate] (4.182 ms) : 0, 4182
IAST [baseline] (30.399 ms) : 0, 30399
IAST [candidate] (31.761 ms) : 0, 31761
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.276 ms) : 3231, 3320
. : milestone, 3276,
iast_FULL (5.79 ms) : 5733, 5848
. : milestone, 5790,
iast_GLOBAL (3.604 ms) : 3553, 3655
. : milestone, 3604,
profiling (1.944 ms) : 1928, 1960
. : milestone, 1944,
tracing (1.779 ms) : 1764, 1793
. : milestone, 1779,
section candidate
no_agent (1.209 ms) : 1197, 1221
. : milestone, 1209,
iast (3.108 ms) : 3069, 3147
. : milestone, 3108,
iast_FULL (5.833 ms) : 5774, 5891
. : milestone, 5833,
iast_GLOBAL (3.616 ms) : 3561, 3671
. : milestone, 3616,
profiling (1.884 ms) : 1868, 1900
. : milestone, 1884,
tracing (1.791 ms) : 1775, 1806
. : milestone, 1791,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (17.868 ms) : 17685, 18051
. : milestone, 17868,
appsec (18.351 ms) : 18161, 18540
. : milestone, 18351,
code_origins (18.375 ms) : 18189, 18562
. : milestone, 18375,
iast (19.412 ms) : 19213, 19610
. : milestone, 19412,
profiling (20.167 ms) : 19968, 20366
. : milestone, 20167,
tracing (18.37 ms) : 18183, 18557
. : milestone, 18370,
section candidate
no_agent (17.075 ms) : 16901, 17248
. : milestone, 17075,
appsec (18.45 ms) : 18259, 18641
. : milestone, 18450,
code_origins (18.593 ms) : 18406, 18779
. : milestone, 18593,
iast (18.481 ms) : 18294, 18668
. : milestone, 18481,
profiling (19.214 ms) : 19022, 19406
. : milestone, 19214,
tracing (19.408 ms) : 19213, 19603
. : milestone, 19408,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.671 ms) : 3457, 3886
. : milestone, 3671,
iast (2.205 ms) : 2141, 2269
. : milestone, 2205,
iast_GLOBAL (2.255 ms) : 2190, 2319
. : milestone, 2255,
profiling (2.06 ms) : 2008, 2112
. : milestone, 2060,
tracing (2.026 ms) : 1977, 2076
. : milestone, 2026,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.748 ms) : 3529, 3966
. : milestone, 3748,
iast (2.216 ms) : 2152, 2280
. : milestone, 2216,
iast_GLOBAL (2.238 ms) : 2174, 2302
. : milestone, 2238,
profiling (2.079 ms) : 2025, 2132
. : milestone, 2079,
tracing (2.033 ms) : 1983, 2083
. : milestone, 2033,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c5e6eccd00, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (14.792 s) : 14792000, 14792000
. : milestone, 14792000,
appsec (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
iast (18.46 s) : 18460000, 18460000
. : milestone, 18460000,
iast_GLOBAL (17.862 s) : 17862000, 17862000
. : milestone, 17862000,
profiling (15.788 s) : 15788000, 15788000
. : milestone, 15788000,
tracing (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
section candidate
no_agent (15.483 s) : 15483000, 15483000
. : milestone, 15483000,
appsec (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
iast (18.712 s) : 18712000, 18712000
. : milestone, 18712000,
iast_GLOBAL (18.275 s) : 18275000, 18275000
. : milestone, 18275000,
profiling (15.607 s) : 15607000, 15607000
. : milestone, 15607000,
tracing (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
|
dfeae3d to
c5e6ecc
Compare
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s try it then!
igoragoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drops from consistently >10% on master right now to 2-5% on this branch
🤩
I looked at some other petclinic scenario results, most have a low CV (<10%) as well.
What Does This Do
This PR increases our
high_loadbenchmark warmup time period to 165s and reduces ourpetclinicrepetitions to 2 in order to keep the total CI runtime roughly the same.Motivation
After experimenting with @igoragoli, his detailed analyses (TYSM 🙏 ), and building off of #9567, this warm up time has shown to improve benchmark stability without drastically increasing CI time. The coefficient of variation for
agg_http_req_duration_p50drops from consistently >10% onmasterright now to 2-5% on this branch. Results in the BP UI for this branch.Let's try this out and adjust again if needed!
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]