Skip to content

Add support for Guava and FastUtil #9727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpbempel merged 2 commits into from
Oct 14, 2025
Merged

Add support for Guava and FastUtil #9727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3e167d
Add support for Guava and FastUtil
jpbempel Oct 10, 2025
fd45ccd
use a list for safe packages
jpbempel Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 25 additions & 14 deletions ...ugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/util/WellKnownClasses.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import java.util.Date;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.OptionalDouble;
Expand Down Expand Up @@ -187,6 +188,22 @@ public class WellKnownClasses {
THROWABLE_SPECIAL_FIELDS.put("cause", ThrowableFields::cause);
}

private static final List<String> SAFE_COLLECTION_PACKAGES =
Arrays.asList(
"java.", // JDK base module
"com.google.protobuf.", // Google ProtoBuf
"com.google.common.collect.", // Google Guava
"it.unimi.dsi.fastutil." // fastutil
);

private static final List<String> SAFE_MAP_PACKAGES =
Arrays.asList(
"java.", // JDK base module
"com.google.protobuf.", // Google ProtoBuf
"com.google.common.collect.", // Google Guava
"it.unimi.dsi.fastutil." // fastutil
);

/**
* @return true if type is a final class and toString implementation is well known and side effect
* free
Expand All @@ -207,27 +224,21 @@ public static boolean isToStringSafe(String concreteType) {
/** @return true if collection implementation is safe to call (only in-memory) */
public static boolean isSafe(Collection<?> collection) {
String className = collection.getClass().getTypeName();
if (className.startsWith("java.")) {
// All Collection implementations from JDK base module are considered as safe
return true;
}
if (className.startsWith("com.google.protobuf.")) {
// All Collection implementations from Google ProtoBuf are considered as safe
return true;
for (String safePackage : SAFE_COLLECTION_PACKAGES) {
if (className.startsWith(safePackage)) {
return true;
}
}
return false;
}

/** @return true if map implementation is safe to call (only in-memory) */
public static boolean isSafe(Map<?, ?> map) {
String className = map.getClass().getTypeName();
if (className.startsWith("java.")) {
// All Map implementations from JDK base module are considered as safe
return true;
}
if (className.startsWith("com.google.protobuf.")) {
// All Map implementations from Google ProtoBuf are considered as safe
return true;
for (String safePackage : SAFE_MAP_PACKAGES) {
if (className.startsWith(safePackage)) {
return true;
}
}
return false;
}
Expand Down