-
Notifications
You must be signed in to change notification settings - Fork 323
Fixed tests for lettuce 7.x #9746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: b988783 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017594
Total [baseline] (10.612 s) : 0, 10612030
Agent [candidate] (1.016 s) : 0, 1015921
Total [candidate] (10.618 s) : 0, 10618042
section appsec
Agent [baseline] (1.2 s) : 0, 1200377
Total [baseline] (11.031 s) : 0, 11031147
Agent [candidate] (1.208 s) : 0, 1207547
Total [candidate] (11.188 s) : 0, 11187530
section iast
Agent [baseline] (1.16 s) : 0, 1159922
Total [baseline] (11.016 s) : 0, 11016198
Agent [candidate] (1.169 s) : 0, 1169317
Total [candidate] (11.065 s) : 0, 11064651
section profiling
Agent [baseline] (1.166 s) : 0, 1166372
Total [baseline] (11.005 s) : 0, 11005407
Agent [candidate] (1.163 s) : 0, 1162665
Total [candidate] (11.092 s) : 0, 11091653
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (692.972 ms) : 0, 692972
BytebuddyAgent [candidate] (692.929 ms) : 0, 692929
GlobalTracer [baseline] (241.987 ms) : 0, 241987
GlobalTracer [candidate] (241.786 ms) : 0, 241786
AppSec [baseline] (32.519 ms) : 0, 32519
AppSec [candidate] (32.199 ms) : 0, 32199
Debugger [baseline] (6.4 ms) : 0, 6400
Debugger [candidate] (6.338 ms) : 0, 6338
Remote Config [baseline] (716.68 µs) : 0, 717
Remote Config [candidate] (706.179 µs) : 0, 706
Telemetry [baseline] (9.298 ms) : 0, 9298
Telemetry [candidate] (9.177 ms) : 0, 9177
Flare Poller [baseline] (10.95 ms) : 0, 10950
Flare Poller [candidate] (10.119 ms) : 0, 10119
section appsec
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (721.789 ms) : 0, 721789
BytebuddyAgent [candidate] (727.284 ms) : 0, 727284
GlobalTracer [baseline] (235.44 ms) : 0, 235440
GlobalTracer [candidate] (237.359 ms) : 0, 237359
IAST [baseline] (24.99 ms) : 0, 24990
IAST [candidate] (25.071 ms) : 0, 25071
AppSec [baseline] (176.212 ms) : 0, 176212
AppSec [candidate] (175.611 ms) : 0, 175611
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (6.196 ms) : 0, 6196
Remote Config [baseline] (636.1 µs) : 0, 636
Remote Config [candidate] (634.898 µs) : 0, 635
Telemetry [baseline] (8.53 ms) : 0, 8530
Telemetry [candidate] (8.618 ms) : 0, 8618
Flare Poller [baseline] (3.923 ms) : 0, 3923
Flare Poller [candidate] (4.01 ms) : 0, 4010
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (821.654 ms) : 0, 821654
BytebuddyAgent [candidate] (829.121 ms) : 0, 829121
GlobalTracer [baseline] (233.076 ms) : 0, 233076
GlobalTracer [candidate] (234.607 ms) : 0, 234607
IAST [baseline] (26.674 ms) : 0, 26674
IAST [candidate] (27.144 ms) : 0, 27144
AppSec [baseline] (35.541 ms) : 0, 35541
AppSec [candidate] (35.404 ms) : 0, 35404
Debugger [baseline] (6.166 ms) : 0, 6166
Debugger [candidate] (6.177 ms) : 0, 6177
Remote Config [baseline] (607.083 µs) : 0, 607
Remote Config [candidate] (616.129 µs) : 0, 616
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.799 ms) : 0, 8799
Flare Poller [baseline] (4.308 ms) : 0, 4308
Flare Poller [candidate] (4.179 ms) : 0, 4179
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (724.036 ms) : 0, 724036
BytebuddyAgent [candidate] (722.065 ms) : 0, 722065
GlobalTracer [baseline] (218.395 ms) : 0, 218395
GlobalTracer [candidate] (218.232 ms) : 0, 218232
AppSec [baseline] (32.614 ms) : 0, 32614
AppSec [candidate] (32.343 ms) : 0, 32343
Debugger [baseline] (6.501 ms) : 0, 6501
Debugger [candidate] (7.298 ms) : 0, 7298
Remote Config [baseline] (854.513 µs) : 0, 855
Remote Config [candidate] (803.15 µs) : 0, 803
Telemetry [baseline] (15.363 ms) : 0, 15363
Telemetry [candidate] (15.093 ms) : 0, 15093
Flare Poller [baseline] (4.922 ms) : 0, 4922
Flare Poller [candidate] (4.138 ms) : 0, 4138
ProfilingAgent [baseline] (109.009 ms) : 0, 109009
ProfilingAgent [candidate] (107.87 ms) : 0, 107870
Profiling [baseline] (110.021 ms) : 0, 110021
Profiling [candidate] (109.132 ms) : 0, 109132
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025964
Total [baseline] (8.691 s) : 0, 8690647
Agent [candidate] (1.018 s) : 0, 1017790
Total [candidate] (8.654 s) : 0, 8654228
section iast
Agent [baseline] (1.149 s) : 0, 1149192
Total [baseline] (9.293 s) : 0, 9293374
Agent [candidate] (1.148 s) : 0, 1148125
Total [candidate] (9.273 s) : 0, 9272577
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (699.741 ms) : 0, 699741
BytebuddyAgent [candidate] (694.701 ms) : 0, 694701
GlobalTracer [baseline] (243.737 ms) : 0, 243737
GlobalTracer [candidate] (242.081 ms) : 0, 242081
AppSec [baseline] (32.741 ms) : 0, 32741
AppSec [candidate] (32.396 ms) : 0, 32396
Debugger [baseline] (6.507 ms) : 0, 6507
Debugger [candidate] (6.417 ms) : 0, 6417
Remote Config [baseline] (720.142 µs) : 0, 720
Remote Config [candidate] (705.713 µs) : 0, 706
Telemetry [baseline] (9.395 ms) : 0, 9395
Telemetry [candidate] (9.421 ms) : 0, 9421
Flare Poller [baseline] (10.223 ms) : 0, 10223
Flare Poller [candidate] (9.451 ms) : 0, 9451
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (814.337 ms) : 0, 814337
BytebuddyAgent [candidate] (813.661 ms) : 0, 813661
GlobalTracer [baseline] (230.911 ms) : 0, 230911
GlobalTracer [candidate] (230.784 ms) : 0, 230784
IAST [baseline] (26.363 ms) : 0, 26363
IAST [candidate] (26.298 ms) : 0, 26298
AppSec [baseline] (35.099 ms) : 0, 35099
AppSec [candidate] (34.943 ms) : 0, 34943
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (6.131 ms) : 0, 6131
Remote Config [baseline] (601.787 µs) : 0, 602
Remote Config [candidate] (622.046 µs) : 0, 622
Telemetry [baseline] (8.604 ms) : 0, 8604
Telemetry [candidate] (8.58 ms) : 0, 8580
Flare Poller [baseline] (4.171 ms) : 0, 4171
Flare Poller [candidate] (4.178 ms) : 0, 4178
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section baseline
no_agent (4.537 ms) : 4480, 4594
. : milestone, 4537,
iast (9.726 ms) : 9563, 9890
. : milestone, 9726,
iast_FULL (14.205 ms) : 13924, 14486
. : milestone, 14205,
iast_GLOBAL (10.422 ms) : 10238, 10606
. : milestone, 10422,
profiling (8.633 ms) : 8492, 8775
. : milestone, 8633,
tracing (7.595 ms) : 7481, 7709
. : milestone, 7595,
section candidate
no_agent (4.394 ms) : 4344, 4445
. : milestone, 4394,
iast (9.94 ms) : 9776, 10104
. : milestone, 9940,
iast_FULL (14.4 ms) : 14113, 14687
. : milestone, 14400,
iast_GLOBAL (10.376 ms) : 10192, 10559
. : milestone, 10376,
profiling (8.542 ms) : 8402, 8683
. : milestone, 8542,
tracing (7.99 ms) : 7874, 8106
. : milestone, 7990,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section baseline
no_agent (36.41 ms) : 36115, 36706
. : milestone, 36410,
appsec (50.087 ms) : 49632, 50542
. : milestone, 50087,
code_origins (44.443 ms) : 44071, 44815
. : milestone, 44443,
iast (46.109 ms) : 45709, 46508
. : milestone, 46109,
profiling (46.364 ms) : 45941, 46788
. : milestone, 46364,
tracing (42.971 ms) : 42614, 43329
. : milestone, 42971,
section candidate
no_agent (37.044 ms) : 36745, 37343
. : milestone, 37044,
appsec (49.49 ms) : 49057, 49923
. : milestone, 49490,
code_origins (44.459 ms) : 44078, 44839
. : milestone, 44459,
iast (45.06 ms) : 44664, 45457
. : milestone, 45060,
profiling (48.901 ms) : 48434, 49369
. : milestone, 48901,
tracing (44.044 ms) : 43682, 44406
. : milestone, 44044,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section baseline
no_agent (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
appsec (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
iast (18.816 s) : 18816000, 18816000
. : milestone, 18816000,
iast_GLOBAL (18.121 s) : 18121000, 18121000
. : milestone, 18121000,
profiling (15.989 s) : 15989000, 15989000
. : milestone, 15989000,
tracing (15.207 s) : 15207000, 15207000
. : milestone, 15207000,
section candidate
no_agent (15.214 s) : 15214000, 15214000
. : milestone, 15214000,
appsec (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
iast (18.557 s) : 18557000, 18557000
. : milestone, 18557000,
iast_GLOBAL (18.005 s) : 18005000, 18005000
. : milestone, 18005000,
profiling (15.44 s) : 15440000, 15440000
. : milestone, 15440000,
tracing (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b988783c8e, baseline=1.55.0-SNAPSHOT~7950d54fef
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (2.528 ms) : 2474, 2582
. : milestone, 2528,
iast (2.224 ms) : 2160, 2289
. : milestone, 2224,
iast_GLOBAL (2.274 ms) : 2209, 2339
. : milestone, 2274,
profiling (2.085 ms) : 2032, 2138
. : milestone, 2085,
tracing (2.035 ms) : 1985, 2084
. : milestone, 2035,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.478 ms) : 2427, 2530
. : milestone, 2478,
iast (2.224 ms) : 2160, 2288
. : milestone, 2224,
iast_GLOBAL (2.261 ms) : 2196, 2325
. : milestone, 2261,
profiling (2.086 ms) : 2032, 2139
. : milestone, 2086,
tracing (2.043 ms) : 1993, 2093
. : milestone, 2043,
|
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
vandonr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
5dd70b0 to
1a4a1b4
Compare
1a4a1b4 to
b988783
Compare
What Does This Do
Fixed tests for lettuce 7.x
Motivation
Additional Notes
In Lettuce 7, connection-related methods (like
flushCommands,isOpenandsetAutoFlushCommands) were removed from the*CommandsAPIs and moved to StatefulConnection.This decouples command execution from connection management, simplifies the API, prevents misuse, but broke our tests.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]