v5.37.1 proposal

[watson]

• [77abd1e28e] - (SEMVER-PATCH) [DI] Workaround bug in AsyncLocalStorage which would otherwise throw (Thomas Watson) #5290
• [172bc66a6b] - (SEMVER-PATCH) Clean up benchmark Sirun Dockerfile (Thomas Watson) #5287
• [052a83379a] - (SEMVER-PATCH) Increase GraphQL benchmark stability (Thomas Watson) #5284
• [0e841468c5] - (SEMVER-PATCH) Increase the benchmark timeout from 15 to 20 minutes (Thomas Watson) #5286
• [e6ea5fd0c3] - (SEMVER-PATCH) [test optimization] Change failed test replay to opt out rather than opt in (Juan Antonio Fernández de Alba) #5283
• [14a3795c31] - (SEMVER-PATCH) Bump esbuild dev-dependency from 0.16.12 to 0.25.0 (Thomas Watson) #5285
• [f9bf2f5edb] - (SEMVER-PATCH) ESLint: Don't ignore specific appsec file (Thomas Watson) #5280

[github-actions]

Overall package size

Self size: 8.75 MB
Deduped: 94.95 MB
No deduping: 95.46 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v5.x@63d878e). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             v5.x    #5295   +/-   ##
=======================================
  Coverage        ?   80.91%           
=======================================
  Files           ?      489           
  Lines           ?    21830           
  Branches        ?        0           
=======================================
  Hits            ?    17664           
  Misses          ?     4166           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datadog-datadog-prod-us1]

Datadog Report

Branch report: v5.37.1-proposal
Commit report: d565ff0
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 16m 27.28s Total Time

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-02-19 11:30:04

Comparing candidate commit b0b0af8 in PR branch v5.37.1-proposal with baseline commit 63d878e in branch v5.x.

Found 69 performance improvements and 0 performance regressions! Performance is the same for 845 metrics, 19 unstable metrics.

scenario:plugin-graphql-control-18

• 🟩 cpu_user_time [-2.057s; -2.046s] or [-87.534%; -87.088%]
• 🟩 execution_time [-2.394s; -2.371s] or [-87.682%; -86.834%]
• 🟩 instructions [-4.7G instructions; -4.7G instructions] or [-86.471%; -85.928%]
• 🟩 max_rss_usage [-401.676MB; -401.448MB] or [-83.688%; -83.640%]

scenario:plugin-graphql-control-20

• 🟩 cpu_user_time [-1.958s; -1.869s] or [-88.214%; -84.239%]
• 🟩 execution_time [-2.250s; -2.211s] or [-87.024%; -85.525%]
• 🟩 instructions [-4.5G instructions; -4.2G instructions] or [-89.370%; -83.581%]
• 🟩 max_rss_usage [-409.271MB; -408.732MB] or [-84.456%; -84.345%]

scenario:plugin-graphql-control-22

• 🟩 cpu_user_time [-2.004s; -1.980s] or [-88.398%; -87.324%]
• 🟩 execution_time [-2.314s; -2.283s] or [-88.313%; -87.158%]
• 🟩 instructions [-4.6G instructions; -4.5G instructions] or [-88.370%; -85.625%]
• 🟩 max_rss_usage [-408.718MB; -399.010MB] or [-84.207%; -82.207%]

scenario:plugin-graphql-with-async-hooks-18

• 🟩 cpu_user_time [-4.076s; -4.040s] or [-91.876%; -91.075%]
• 🟩 execution_time [-4.421s; -4.384s] or [-91.464%; -90.702%]
• 🟩 instructions [-7.8G instructions; -7.5G instructions] or [-91.237%; -88.163%]
• 🟩 max_rss_usage [-444.968MB; -444.469MB] or [-84.112%; -84.018%]

scenario:plugin-graphql-with-async-hooks-20

• 🟩 cpu_user_time [-3.706s; -3.650s] or [-91.389%; -90.010%]
• 🟩 execution_time [-4.061s; -4.035s] or [-90.687%; -90.110%]
• 🟩 instructions [-7.1G instructions; -6.9G instructions] or [-91.062%; -88.426%]
• 🟩 max_rss_usage [-454.199MB; -451.580MB] or [-85.230%; -84.738%]

scenario:plugin-graphql-with-async-hooks-22

• 🟩 cpu_user_time [-3.703s; -3.646s] or [-92.354%; -90.942%]
• 🟩 execution_time [-4.124s; -4.111s] or [-91.584%; -91.294%]
• 🟩 instructions [-7.3G instructions; -7.3G instructions] or [-90.748%; -89.816%]
• 🟩 max_rss_usage [-568.565MB; -567.128MB] or [-87.171%; -86.950%]

scenario:plugin-graphql-with-depth-and-collapse-off-18

• 🟩 cpu_user_time [-16.562s; -15.546s] or [-93.574%; -87.833%]
• 🟩 execution_time [-17.605s; -16.601s] or [-93.211%; -87.891%]
• 🟩 instructions [-38.4G instructions; -38.3G instructions] or [-91.413%; -91.203%]
• 🟩 max_rss_usage [-1.131GB; -1.100GB] or [-89.453%; -86.988%]

scenario:plugin-graphql-with-depth-and-collapse-off-20

• 🟩 instructions [-58.3G instructions; -57.7G instructions] or [-93.578%; -92.680%]
• 🟩 max_rss_usage [-2.282GB; -2.276GB] or [-91.974%; -91.756%]

scenario:plugin-graphql-with-depth-and-collapse-off-22

• 🟩 execution_time [-24.877s; -22.485s] or [-96.842%; -87.530%]
• 🟩 instructions [-56.7G instructions; -56.7G instructions] or [-92.982%; -92.913%]
• 🟩 max_rss_usage [-2.371GB; -2.365GB] or [-91.984%; -91.746%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

• 🟩 cpu_user_time [-9.810s; -9.719s] or [-91.081%; -90.231%]
• 🟩 execution_time [-10.437s; -10.416s] or [-90.477%; -90.290%]
• 🟩 instructions [-21.5G instructions; -21.4G instructions] or [-90.544%; -90.201%]
• 🟩 max_rss_usage [-745.062MB; -734.950MB] or [-86.135%; -84.966%]

scenario:plugin-graphql-with-depth-and-collapse-on-20

• 🟩 cpu_user_time [-16.094s; -16.059s] or [-91.982%; -91.783%]
• 🟩 execution_time [-17.748s; -17.617s] or [-92.237%; -91.557%]
• 🟩 instructions [-43.5G instructions; -43.2G instructions] or [-93.544%; -92.897%]
• 🟩 max_rss_usage [-1.991GB; -1.987GB] or [-92.140%; -91.946%]

scenario:plugin-graphql-with-depth-and-collapse-on-22

• 🟩 cpu_user_time [-16.405s; -15.604s] or [-94.675%; -90.054%]
• 🟩 execution_time [-17.992s; -17.134s] or [-94.531%; -90.023%]
• 🟩 instructions [-43.0G instructions; -42.8G instructions] or [-93.200%; -92.858%]
• 🟩 max_rss_usage [-1.991GB; -1.986GB] or [-91.812%; -91.548%]

scenario:plugin-graphql-with-depth-off-18

• 🟩 cpu_user_time [-10.176s; -9.966s] or [-91.701%; -89.809%]
• 🟩 execution_time [-10.857s; -10.606s] or [-91.507%; -89.387%]
• 🟩 instructions [-22.5G instructions; -22.5G instructions] or [-90.562%; -90.470%]
• 🟩 max_rss_usage [-730.267MB; -729.612MB] or [-85.224%; -85.148%]

scenario:plugin-graphql-with-depth-off-20

• 🟩 cpu_user_time [-17.133s; -15.833s] or [-95.612%; -88.355%]
• 🟩 execution_time [-18.803s; -17.346s] or [-95.692%; -88.278%]
• 🟩 instructions [-45.0G instructions; -44.0G instructions] or [-94.420%; -92.181%]
• 🟩 max_rss_usage [-2.003GB; -1.998GB] or [-92.137%; -91.940%]

scenario:plugin-graphql-with-depth-off-22

• 🟩 cpu_user_time [-16.675s; -15.869s] or [-94.688%; -90.113%]
• 🟩 execution_time [-18.322s; -17.419s] or [-94.642%; -89.980%]
• 🟩 instructions [-44.3G instructions; -43.8G instructions] or [-93.664%; -92.570%]
• 🟩 max_rss_usage [-2.002GB; -2.001GB] or [-91.729%; -91.700%]

scenario:plugin-graphql-with-depth-on-max-18

• 🟩 cpu_user_time [-9.927s; -9.572s] or [-92.334%; -89.032%]
• 🟩 execution_time [-10.531s; -10.297s] or [-91.419%; -89.381%]
• 🟩 instructions [-21.6G instructions; -21.3G instructions] or [-91.062%; -89.669%]
• 🟩 max_rss_usage [-743.750MB; -735.813MB] or [-86.022%; -85.104%]

scenario:plugin-graphql-with-depth-on-max-20

• 🟩 cpu_user_time [-16.351s; -16.016s] or [-92.893%; -90.989%]
• 🟩 execution_time [-17.897s; -17.633s] or [-92.613%; -91.250%]
• 🟩 instructions [-43.7G instructions; -43.2G instructions] or [-93.848%; -92.622%]
• 🟩 max_rss_usage [-1.993GB; -1.985GB] or [-92.241%; -91.846%]

scenario:plugin-graphql-with-depth-on-max-22

• 🟩 cpu_user_time [-16.163s; -15.461s] or [-94.310%; -90.217%]
• 🟩 execution_time [-17.761s; -17.089s] or [-93.983%; -90.429%]
• 🟩 instructions [-42.8G instructions; -42.7G instructions] or [-93.141%; -92.900%]
• 🟩 max_rss_usage [-1.990GB; -1.989GB] or [-91.697%; -91.669%]

[BridgeAR]

Changes are LGTM, while I'd still like a second review.