Conversation
* Split appsec telemetry file into rasp, waf and user * split appsec telemetry test files * remove unused success param * fix user test file name
I ported an open PR and added additional fixes to the code. The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. The `DogStatsDClient` is also missing the decrement method. Instead, the increment method was used by the the custom metric implementation. This is adjusted. Please check the commit messages for further information. Fixes #4285 Closes #5241 The `NoopDogStatsDClient` gets used by default in unit tests. However, it is missing the `decrement` method which causes tests to throw exceptions when trying to call it. --------- Co-authored-by: Justin Johnson <booleangate@gmail.com>
Overall package sizeSelf size: 8.81 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5343 +/- ##
=======================================
Coverage ? 80.60%
=======================================
Files ? 487
Lines ? 21760
Branches ? 0
=======================================
Hits ? 17540
Misses ? 4220
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 669 Passed, 0 Skipped, 13m 28.84s Total Time |
BenchmarksBenchmark execution time: 2025-02-28 10:19:21 Comparing candidate commit 30c2213 in PR branch Found 26 performance improvements and 11 performance regressions! Performance is the same for 880 metrics, 16 unstable metrics. scenario:appsec-iast-startup-time-control-22
scenario:appsec-iast-startup-time-iast-enabled-20
scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22
scenario:appsec-startup-time-appsec-enabled-20
scenario:appsec-startup-time-control-22
scenario:exporting-pipeline-0.5-18
scenario:exporting-pipeline-0.5-20
scenario:exporting-pipeline-0.5-22
scenario:log-skip-log-20
scenario:log-with-debug-20
scenario:log-with-debug-22
scenario:log-with-error-20
scenario:log-with-error-22
scenario:log-without-log-20
scenario:log-without-log-22
scenario:plugin-q-with-tracer-22
scenario:spans-finish-later-22
scenario:startup-with-tracer-20
scenario:startup-with-tracer-22
|
|
closing to do a minor instead to include #5198 |
522aa56c7d] - (SEMVER-PATCH) lazy load public api + profiling + crashtracking + span stats (Roch Devost) #52565f9757c9d2] - (SEMVER-PATCH) Add missing decrement method to DogStatsDClient (Ruben Bridgewater) #53307880319596] - (SEMVER-PATCH) Add TODO comment about appsec code in RC index (simon-id) #5339e7f7a2fcde] - (SEMVER-PATCH) [test optimization] Fix possible crash with known tests (Juan Antonio Fernández de Alba) #5328845120d8cf] - (SEMVER-PATCH) CI: Remove unused GH Actions (Thomas Watson) #5332bc1450a1b6] - (SEMVER-PATCH) CI: Run some GH action jobs on the latest Node.js version as well (Thomas Watson) #53259571c02642] - (SEMVER-PATCH) CI: Remove redundant GH Action steps (Thomas Watson) #533110da8f2994] - (SEMVER-PATCH) [test optimization] Lazy load failed test replay logic (Juan Antonio Fernández de Alba) #5327d36907b672] - (SEMVER-PATCH) Split appsec telemetry file into rasp, waf and user (Ilyas Shabi) #5303