Merged
Conversation
…t argument (#5372) * fix checking for stream option * add small safety check * lint
* update native appsec * report appsec block failed * report truncation tags * add error blocking log * failed graphql blocking tag * report after block * add waf timeout span tag * add rasp timeout span tag * add waf error tag * add rasp error tag * remove raspRule from waf run call * add waf wrapper tests * report metrics after blocking * call runWaf * rasp timout test * add waf/rasp errors and timeout * report metrics after catch on graphql * return false if waf result is not defined * graphql blocking action * graphql report metrics * check if request data exist first * user tracking blocking action * waf and rasp timeout * fix sql injection tests * add comment for waf timeout * keep only waf error test * fallback to dummy BlockList for cypress 6 * fix linter * add waf error test * fix rasp resources path * fix waf error on windows * fix waf error on windows path * remove waf errors test file * report waf metrics on api security schema extraction * report metrics inside run waf * user blocking tests * add reporter tests * linter * add test for block failure * use settag instead of addtags * metrics order * fix linter and test * remove return null * add waf context run stubs * waf error code readability * fix timers * report metrics on waf failure * fix metrics * remove run waf function * add unit tests * add telemetry tests * test message * replace total runtime with duration * reporter test * test title * add more tests
* skip tests on tag * remove special casing of my branch
…rough the OpenAI SDK (#5381) * check base url for azure openai, deepseek * tests * re-trigger ci
* bump axios * fix http header fingerprint
…racing all embeddings calls (#4970) * generic embeddings patching * add tests * remove unneeded name var * add removed openai external test dependency * remove flaky test * remove comments * fixes
Co-authored-by: Ilyas Shabi <ilyas.shabi@datadoghq.com>
* fix babel helpers regex vulnerability error * update 3rd party license * fix test no longer running on older unsupported node version * Fix user agent in fingerprinting tests (#5402) --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
…ion (#5369) * initial integration * finish apm instrumentation * check request string type * add result to context instead of spreading * support from 1.0.0 * standardize tag * change promise handling in instrumentation * test init * clean up patching * esm test * add some tests * type definitions * ci workflow * CODEOWNERS change * add remaining tests * remove for ... in * add history to tests * configuration * tools * tag error on stream
* Add consistent sampling via knuth's method * remove code changes from doc changes * better match existing semantics * fix test * they are the same * apply feedback
* ssi tests gitlab ci
fix llmobs.AnnotationOptions comment Co-authored-by: k.masachika <138270651+mkdev10@users.noreply.github.com>
Ensure that `*.spec.js` files inside of sub-directories of the `packages/datadog-instrumentations/test` folder are also run in CI. Today, there's a `helpers` directory, which currently contains a single spec file. Since this spec file isn't run during CI, it's been silently broken since 2022. Therefore, this commit also updates the spec file to work, by: - Fixing references to missing variables - Changing it from tap to mocha, as this is the style of the other spec files in the package
The root of the `datadog-instrumentations` package is reserved for module instrumentation code. The `check_require_cache.js` file is a helper file and should be in a sub-directory. This commit also consolidates the `helpers` and `utils` folders as they served the same purpose.
Contributor
Overall package sizeSelf size: 8.96 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.0 | 19.26 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5420 +/- ##
=======================================
Coverage ? 79.46%
=======================================
Files ? 510
Lines ? 22824
Branches ? 0
=======================================
Hits ? 18138
Misses ? 4686
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 800 Passed, 0 Skipped, 14m 12.39s Total Time |
BenchmarksBenchmark execution time: 2025-03-14 18:20:13 Comparing candidate commit ea79bb6 in PR branch Found 0 performance improvements and 9 performance regressions! Performance is the same for 908 metrics, 16 unstable metrics. scenario:startup-control-everything-18
scenario:startup-control-everything-20
scenario:startup-control-everything-22
scenario:startup-with-tracer-everything-18
scenario:startup-with-tracer-everything-20
scenario:startup-with-tracer-everything-22
|
duncanista
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4f0481edd2] - (SEMVER-PATCH) Refactor: Move check_require_cache code to helpers folder (Thomas Watson) #54164cfe991f89] - (SEMVER-PATCH) CI: Run spec files in datadog-instrumentations sub-dirs (Thomas Watson) #5417e9f665c64f] - (SEMVER-PATCH) lazy load ip extraction (Roch Devost) #53992196c24b61] - (SEMVER-PATCH) llmobs.AnnotationOptions typo (Sam Brenner) #541847f5ac907e] - (SEMVER-PATCH) SSI tests gitlab ci (Roberto Montero) #5349598409d2fd] - [test optimization] Deprecate dd-trace support for cypress <10.2.0 (Juan Antonio Fernández de Alba)0bffaa17fd] - (SEMVER-PATCH) always disable fs integration in serverless (Roch Devost) #5412a68768fb2a] - (SEMVER-PATCH) remove fs dependency from lambda hook (Roch Devost) #5404f474d01c57] - (SEMVER-PATCH) Adds JSDoc types to much of the sampling code (Brian Marks) #53921206bdc983] - (SEMVER-PATCH) [test optimization] Fix hooks and retries logic in mocha (Juan Antonio Fernández de Alba) #539865c19997b2] - (SEMVER-MINOR) [MLOB-2340] feat(vertexai): add@google-cloud/vertexaiinstrumentation (Sam Brenner) #536939df8d31e4] - fix babel helpers regex vulnerability error (Roch Devost) #5402647d4be0a6] - (SEMVER-PATCH) [test optimization] Fix git commit message extraction (Juan Antonio Fernández de Alba) #5390589c06127a] - (SEMVER-PATCH) Remove version tag in telemetry metrics (Santiago M. Mola) #538252279e0e0f] - (SEMVER-PATCH) Fix reporting of profiling_enabled in startup log (Attila Szegedi) #53832477649418] - (SEMVER-MINOR) [MLOB-1954] feat(langchain): generically patch embeddings to enable tracing all embeddings calls (Sam Brenner) #497003fb62c340] - (SEMVER-PATCH) bump axios (Ilyas Shabi) #5387cdaab0b930] - (SEMVER-MINOR) [test optimization] [SDTEST-1623] Disabled flaky tests implementation (Mario Vidal Domínguez) #53559515d54f30] - (SEMVER-MINOR) feat(llmobs): add support for Azure OpenAI and Deepseek calls made through the OpenAI SDK (Sam Brenner) #5381bfed02ab00] - (SEMVER-PATCH) Skip tests on release (Laplie Anderson) #537321c98cd6ae] - (SEMVER-PATCH) Add first capabilities tagging (Mario Vidal Domínguez) #53216e11e2a1d5] - (SEMVER-MINOR) Report general tags and metrics (Ilyas Shabi) #533505066666e6] - (SEMVER-PATCH) [test optimization] Add auto_injected telemetry tag (Juan Antonio Fernández de Alba) #53791ce996b798] - (SEMVER-PATCH) fix(openai, llmobs): check for stream, and other, options on the first argument (Sam Brenner) #5372