Merged
Conversation
* Report waf init and update success * handle waf init failure * do not report ecent rules when success fails * remove default value of diagnosticsRules * use default args to report init
* fix mysql dbm trace id test * fix mysql2 and pg * code cleanup
* Add integration tag to llmobs spans * Add integration tag to tests
* Add span.finished telemetry metric * Add decorator tag * address comments * Fix root parent bool * Add error tag * Fix boolean coalescing
* use old version of dependency instead of vendoring
* use tar for everything * update test-agent to 1.21.1
… version number (#5463)
…5480) Co-authored-by: FredericEspiau <7319147+FredericEspiau@users.noreply.github.com>
* add llmobs plugin * wip tests * tests + ci workflow * move helper functions outside of class scope * add integration tag * Update packages/dd-trace/test/llmobs/plugins/google-cloud-vertexai/index.spec.js
* waf requests telemetry metrics * fix undefined versions * add more tests * fix tags order * update waf metrics integration test * remove duplicate input_truncated on test * fix waf requests telemtry test * fix rate limiter * report waf error metric * fix updateWafRateLimitedMetric reporter test * fix functions order * change function names * add versions to report attack * fix reporting rate limiting metric
* fix memory leak in runtime.node.heap metrics * switch to promise-based timers for test * add benchmark
* Add raw span size metric * Add processed span event size metrics * Refactor * Remove unnecessary check
Contributor
Overall package sizeSelf size: 9.1 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5487 +/- ##
=======================================
Coverage ? 79.28%
=======================================
Files ? 514
Lines ? 23174
Branches ? 0
=======================================
Hits ? 18373
Misses ? 4801
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 919 Passed, 0 Skipped, 6m 48.75s Total Time |
BenchmarksBenchmark execution time: 2025-03-26 14:21:48 Comparing candidate commit 38b0372 in PR branch Found 5 performance improvements and 6 performance regressions! Performance is the same for 905 metrics, 17 unstable metrics. scenario:plugin-http-server-control-18
scenario:plugin-http-server-control-20
scenario:plugin-http-server-control-22
scenario:plugin-http-server-querystring-obfuscation-18
scenario:plugin-http-server-querystring-obfuscation-20
scenario:plugin-http-server-querystring-obfuscation-22
|
bengl
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8f744b05ff] - (SEMVER-PATCH) Fix iast flaky code injection tests (Ugaitz Urien) #5460ca101dce10] - (SEMVER-PATCH) Add a few TODO's (Thomas Watson) #5477166207260d] - (SEMVER-MINOR) chore(llmobs): add span size telemetry metrics (Yun Kim) #5468288d38bc6f] - (SEMVER-PATCH) fix memory leak in runtime.node.heap.* metrics (Roch Devost) #5476d1d7ccf2aa] - (SEMVER-MINOR) waf requests telemetry metrics (Ilyas Shabi) #53841a74c9b183] - (SEMVER-MINOR) feat(llmobs): add vertexai plugin (Sam Brenner) #5413959c5e6529] - (SEMVER-PATCH) Fix logging null when debugging and sending data without any error (simon-id) #5480f92be45ba7] - (SEMVER-PATCH) [test optimization] [SDTEST-1720] Change capabilities tagging to send version number (Mario Vidal Domínguez) #5463faea8912a2] - (SEMVER-MINOR) [test optimization] [SDTEST-1630] Attempt to fix flaky tests implementation (Mario Vidal Domínguez) #5429fac89882fd] - (SEMVER-PATCH) fix wrong test error message when expected span was not received (Roch Devost) #5447402741bbb4] - (SEMVER-PATCH) make cache action unix compatible and update test agent (Roch Devost) #5464fc756abf6a] - (SEMVER-PATCH) fix connection pool error in mongoose tests (Roch Devost) #5435de5df2a7d4] - (SEMVER-PATCH) fix release script esm error on node 20 (Roch Devost) #53683bff8507eb] - (SEMVER-PATCH) chore(llmobs): add span.finished telemetry metric (Yun Kim) #5444f84216a10e] - (SEMVER-MINOR) feat(llmobs): add integration tag to llmobs spans (Yun Kim) #5465579d213a53] - (SEMVER-PATCH) replace node action cache with custom cache in ci (Roch Devost) #5454174a5cd944] - (SEMVER-PATCH) set dc-polyfill version to 0.1.6 (Roch Devost) #5457f6eefc5993] - (SEMVER-PATCH) retry npm install/view for appsec and plugins tests (Roch Devost) #5434b52b7fae08] - (SEMVER-PATCH) add matrix strategy to llmobs sdk ci job (Roch Devost) #545186cbc0acca] - (SEMVER-PATCH) fix profiling test expectating minimum 2 requests instead of 1 (Roch Devost) #544952a91c9f4a] - (SEMVER-PATCH) fix aws-sdk kinesis flaky dsm test (Roch Devost) #5446fa07ecf5c5] - (SEMVER-PATCH) fix amqplib flaky dsm tests (Roch Devost) #54459d3ec95656] - (SEMVER-PATCH) fix mysql/mysql2/pg dbm trace id tests (Roch Devost) #5436604cfa03ee] - (SEMVER-PATCH) retry test agent start when it fails (Roch Devost) #54438dc7f96e24] - (SEMVER-PATCH) lazy load dd-trace-api integration (Roch Devost) #540638cb93514a] - (SEMVER-PATCH) increase next.js test timeout to 5 minutes (Roch Devost) #54422c5e17c280] - (SEMVER-MINOR) dbm: tedious (sql server) service mode (Thomas Hunter II) #5375c5e5f8c0db] - (SEMVER-PATCH) [test optimization] Improve playwright flakiness (this time for real?) (Juan Antonio Fernández de Alba) #54405e794c7519] - (SEMVER-PATCH) bump native appsec package (Ilyas Shabi) #5439a0fe0c5867] - (SEMVER-MINOR) Report waf init and update success and failure (Ilyas Shabi) #5388450abfffcd] - (SEMVER-PATCH) [test optimization] Fix playwright e2e tests flakiness (Juan Antonio Fernández de Alba) #5438