Skip to content

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Aug 8, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@wconti27 wconti27 marked this pull request as ready for review August 8, 2025 14:16
@wconti27 wconti27 requested review from a team as code owners August 8, 2025 14:16
Copy link

github-actions bot commented Aug 8, 2025

Overall package size

Self size: 11.86 MB
Deduped: 111.47 MB
No deduping: 111.82 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.1.0 | 20.37 MB | 20.37 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.1 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.24%. Comparing base (48755b5) to head (402586a).

Files with missing lines Patch % Lines
packages/datadog-plugin-router/src/index.js 66.66% 1 Missing ⚠️
packages/dd-trace/src/plugins/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6251      +/-   ##
==========================================
- Coverage   83.04%   82.24%   -0.80%     
==========================================
  Files         470      474       +4     
  Lines       19874    19637     -237     
==========================================
- Hits        16504    16151     -353     
- Misses       3370     3486     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Aug 8, 2025

Benchmarks

Benchmark execution time: 2025-08-18 20:07:45

Comparing candidate commit 402586a in PR branch conti/refactor-web-integrations with baseline commit 48755b5 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 1269 metrics, 53 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟥 max_rss_usage [+6.627MB; +12.887MB] or [+5.062%; +9.845%]

@wconti27 wconti27 requested a review from a team as a code owner August 8, 2025 15:34
@simon-id simon-id marked this pull request as draft August 10, 2025 06:32
@simon-id
Copy link
Member

Converted the PR to draft since it says "DRAFT" 😉

@wconti27 wconti27 marked this pull request as ready for review August 11, 2025 16:43
@wconti27 wconti27 assigned wconti27 and unassigned wconti27 Aug 11, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Aug 11, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 402586a | Docs | Was this helpful? Give us feedback!

@wconti27 wconti27 marked this pull request as draft August 15, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants