Skip to content

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Aug 11, 2025

What does this PR do?

Skip dependabot update for major versions of nock nyc and OTel.

Motivation

They break our tests when updated:

#6257
#6057
#5999
#5972

@rochdev rochdev requested a review from a team as a code owner August 11, 2025 14:51
Copy link

Overall package size

Self size: 11.34 MB
Deduped: 110.99 MB
No deduping: 111.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.1.0 | 20.37 MB | 20.37 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.30%. Comparing base (48fd822) to head (324698a).
⚠️ Report is 46 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6259   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files         478      478           
  Lines       19812    19812           
=======================================
  Hits        16504    16504           
  Misses       3308     3308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add these to the list because we could update these. I don't think we should not receive the update for breaking our test reasons.

We should fix the issues instead. Only if that's not possible, then we should skip it.

I am therefore -0.75 on this

Copy link

datadog-official bot commented Aug 11, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

cypress@latest commonJS early flake detection disables early flake detection if known tests should not be requested from integration-tests/cypress/cypress.spec.js (Datadog)
Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/cypress/cypress.spec.js)

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 324698a | Docs | Was this helpful? Give us feedback!

@rochdev
Copy link
Member Author

rochdev commented Aug 11, 2025

I didn't add these to the list because we could update these. I don't think we should not receive the update for breaking our test reasons. We should fix the issues instead. Only if that's not possible, then we should skip it.

I agree in principle, but in practice some of those PRs have been sitting there for months, and previous attempts to fix them seemed to lead nowhere. If we're not going to spend the time to fix them anyway, we should at least ignore them from Dependabot otherwise it's just unnecessary noise.

@BridgeAR
Copy link
Collaborator

Nock was just recently updated to a newer version (while still not being latest). I do still think we should keep the automation for these.

@watson
Copy link
Collaborator

watson commented Aug 26, 2025

If we add these to an ignore list, how do we remember to come back later and fix our tests once we do have time? Should we mark it with a TODO or?

@BridgeAR
Copy link
Collaborator

I suggest we close this for now and if we determine to not update these, we should add a TODO entry individually

@BridgeAR BridgeAR closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants