Skip to content

Use symbol instead of weak map for associating data with contexts #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Use symbol instead of weak map for associating data with contexts #6276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
694bf23
Use symbol instead of weak map for associating data with contexts
szegedi Aug 13, 2025
a5bd5f9
Use private fields in EventPlugin
szegedi Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions packages/dd-trace/src/profiling/profilers/event_plugins/event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,55 +7,55 @@ const { performance } = require('perf_hooks')
// start/error/finish methods to the appropriate diagnostic channels.
// TODO: Decouple this from TracingPlugin.
class EventPlugin extends TracingPlugin {
#eventHandler
#eventFilter
#dataSymbol
#entryType

constructor (eventHandler, eventFilter) {
super()
this.eventHandler = eventHandler
this.eventFilter = eventFilter
this.contextData = new WeakMap()
this.entryType = this.constructor.entryType
this.#eventHandler = eventHandler
this.#eventFilter = eventFilter
this.#entryType = this.constructor.entryType
this.#dataSymbol = Symbol(`dd-trace.profiling.event.${this.#entryType}.${this.constructor.operation}`)
}

start (ctx) {
this.contextData.set(ctx, {
startEvent: ctx,
startTime: performance.now()
})
ctx[this.#dataSymbol] = performance.now()
}

error (ctx) {
const data = this.contextData.get(ctx)
if (data) {
data.error = true
}
// We don't emit perf events for failed operations
ctx[this.#dataSymbol] = undefined
}

finish (ctx) {
const data = this.contextData.get(ctx)

if (!data) return
this.contextData.delete(ctx)
const startTime = ctx[this.#dataSymbol]
if (startTime === undefined) {
return
}
ctx[this.#dataSymbol] = undefined

const { startEvent, startTime, error } = data
if (error || this.ignoreEvent(startEvent)) {
return // don't emit perf events for failed operations or ignored events
if (this.ignoreEvent(ctx)) {
return // don't emit perf events for ignored events
}

const duration = performance.now() - startTime
const event = {
entryType: this.entryType,
entryType: this.#entryType,
startTime,
duration
}

if (!this.eventFilter(event)) {
if (!this.#eventFilter(event)) {
return
}

const context = (ctx.currentStore?.span || this.activeSpan)?.context()
event._ddSpanId = context?.toSpanId()
event._ddRootSpanId = context?._trace.started[0]?.context().toSpanId() || event._ddSpanId

this.eventHandler(this.extendEvent(event, startEvent))
this.#eventHandler(this.extendEvent(event, ctx))
}

ignoreEvent () {
Expand Down
Loading