Skip to content

Conversation

@simon-id
Copy link
Member

@simon-id simon-id commented Dec 18, 2025

What does this PR do?

This PR adds instrumentation for the Stripe SDK, and sends payloads from a couple of methods to the AppSec WAF, that will in turn convert them into span tags for the backend to receive.

Motivation

These tags will be used by the WAF to detect endpoints that handle payments in the Endpoint Catalog, and will be useful for fraud detection and general security observability.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Overall package size

Self size: 4.4 MB
Deduped: 5.22 MB
No deduping: 5.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@simon-id simon-id self-assigned this Dec 18, 2025
@datadog-official

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.45%. Comparing base (11e33bf) to head (b7f5e41).

Files with missing lines Patch % Lines
packages/dd-trace/src/appsec/index.js 30.00% 14 Missing ⚠️
...ages/datadog-instrumentations/src/helpers/hooks.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7138      +/-   ##
==========================================
- Coverage   84.50%   84.45%   -0.06%     
==========================================
  Files         525      525              
  Lines       22489    22510      +21     
==========================================
+ Hits        19005    19011       +6     
- Misses       3484     3499      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2025

Benchmarks

Benchmark execution time: 2026-01-07 07:10:42

Comparing candidate commit b7f5e41 in PR branch stripe_business_events with baseline commit 11e33bf in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants