-
Notifications
You must be signed in to change notification settings - Fork 364
feat(aap): update tags for inferred proxy spans #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Overall package sizeSelf size: 4.42 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7171 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 513 511 -2
Lines 22106 22115 +9
=======================================
+ Hits 19039 19047 +8
- Misses 3067 3068 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✨ Fix all issues with Cursor
|
9e59dbf to
3136e80
Compare
BenchmarksBenchmark execution time: 2026-01-21 19:08:50 Comparing candidate commit 3136e80 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 230 metrics, 30 unstable metrics. |
What does this PR do?
API Gateway v2 (HTTP API) support: Added
aws-httpapito the supported proxies map, generating spans with nameaws.httpapi(in addition to existingaws.apigatewayfor REST API v1).Span attributes improvements:
serverto inferred proxy spanshttps://schemex-dd-proxy-resource-pathheader to populate http.route tagx-dd-proxy-resource-path) when available, falling back to the pathAppSec integration:
_dd.appsec.enabled: 1metric to inferred proxy spans when AppSec is enabledAdditional span tags (when corresponding headers are present):
account_idfromx-dd-proxy-account-idapiidfromx-dd-proxy-api-idregionfromx-dd-proxy-regionaws_userfromx-dd-proxy-userdd_resource_keycomputed as API Gateway ARN:arn:aws:apigateway:{region}::/restapis/{api-id}arn:aws:apigateway:{region}::/apis/{api-id}Motivation
Implementation of RFC-1081 on Endpoint Discovery & Correlation from API Gateway Inferred Spans, summary of changes:
Additional Notes
APPSEC-60015
System test: DataDog/system-tests#5935