Skip to content

Conversation

@szegedi
Copy link
Contributor

@szegedi szegedi commented Jan 5, 2026

What does this PR do?

Default to zstd compression for profile uploads on Node.js 24+

Motivation

We want to make zstd default. zstd is used by default by many other language profilers already and is well supported in the Datadog backend. We could default to ztsd on all supported Node.js versions as we ship a Rust zstd compressor for older Node.js versions, but on 24+ we use the built-in one that runs asynchronously on libuv worker threads, just as gzip does. This is a less disruptive choice than making it default on every version, as older versions would use the Rust zstd compressor that would run on the event loop thread.

Additional Notes

Jira: PROF-11927

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.55%. Comparing base (ecce729) to head (8c30f84).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7172   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         532      532           
  Lines       22641    22642    +1     
=======================================
+ Hits        19144    19145    +1     
  Misses       3497     3497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Overall package size

Self size: 4.38 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

This comment has been minimized.

@szegedi szegedi force-pushed the szegedi/zstd-default branch from 3037557 to 7001200 Compare January 5, 2026 13:43
@pr-commenter
Copy link

pr-commenter bot commented Jan 5, 2026

Benchmarks

Benchmark execution time: 2026-01-09 13:26:14

Comparing candidate commit 8c30f84 in PR branch szegedi/zstd-default with baseline commit ecce729 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 290 metrics, 30 unstable metrics.

@szegedi szegedi marked this pull request as ready for review January 9, 2026 17:56
@szegedi szegedi requested a review from a team as a code owner January 9, 2026 17:56
@BridgeAR BridgeAR merged commit 4392fe1 into master Jan 9, 2026
797 checks passed
@BridgeAR BridgeAR deleted the szegedi/zstd-default branch January 9, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants