test(appsec): set 15s timeout on sequelize plugin spec#7544
Closed
test(appsec): set 15s timeout on sequelize plugin spec#7544
Conversation
Contributor
Overall package sizeSelf size: 4.62 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
DB/Sequelize setup can exceed the default 5s on slow CI runners, causing flaky failures. Set this.timeout(15000) in the sequelize plugin spec only, matching the pattern used in other appsec plugin specs (e.g. next, kafkajs).
watson
force-pushed
the
watson/fix-flake3
branch
from
a9510ba to
53eb9b7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7544 +/- ##
==========================================
- Coverage 80.15% 80.11% -0.04%
==========================================
Files 730 730
Lines 31217 31217
==========================================
- Hits 25023 25011 -12
- Misses 6194 6206 +12 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increases the Mocha timeout for the sequelize AppSec plugin spec to 15s so DB/Sequelize setup can finish on slow CI runners. The timeout is set only in
packages/dd-trace/test/appsec/index.sequelize.plugin.spec.jsviathis.timeout(15000), consistent with other appsec plugin specs (e.g. next, kafkajs).Motivation
The AppSec / mysql job was flaking with "Timeout of 5000ms exceeded" in
index.sequelize.plugin.spec.jswhen runners were slow. Using a per-spec timeout keeps the default 5s for other appsec plugin tests and only relaxes it where DB setup is slow.