Add new function to add endpoint #3381

estringana · 2025-08-18T13:17:14Z

Description

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

codecov-commenter · 2025-08-25T16:08:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.74%. Comparing base (adcd254) to head (a5239ab).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3381   +/-   ##
=======================================
  Coverage   61.73%   61.74%           
=======================================
  Files         141      141           
  Lines       12481    12481           
  Branches     1630     1630           
=======================================
+ Hits         7705     7706    +1     
+ Misses       4055     4054    -1     
  Partials      721      721

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcd254...a5239ab. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2025-08-25T16:40:00Z

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-20 12:25:47

Comparing candidate commit 04332f1 in PR branch estringana/collect-framework-endpoints with baseline commit 9298487 in branch master.

Found 26 performance improvements and 21 performance regressions! Performance is the same for 145 metrics, 2 unstable metrics.

scenario:ContextPropagationBench/benchExtractHeaders128Bit

🟩 execution_time [-58.929ns; -21.071ns] or [-6.567%; -2.348%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

🟩 execution_time [-342.167µs; -80.393µs] or [-10.093%; -2.371%]

scenario:EmptyFileBench/benchEmptyFileDdprof

🟥 mem_peak [+142.524KB; +146.348KB] or [+2.787%; +2.862%]

scenario:HookBench/benchHookOverheadInstallHookOnFunction

🟥 execution_time [+92.285µs; +127.228µs] or [+19.154%; +26.407%]

scenario:HookBench/benchHookOverheadInstallHookOnFunction-opcache

🟥 execution_time [+105.400µs; +135.588µs] or [+22.621%; +29.100%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod

🟥 execution_time [+86.123µs; +118.593µs] or [+16.505%; +22.728%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod-opcache

🟥 execution_time [+91.628µs; +115.517µs] or [+18.853%; +23.768%]

scenario:HookBench/benchHookOverheadTraceFunction

🟥 execution_time [+109.083µs; +113.628µs] or [+53.558%; +55.790%]

scenario:HookBench/benchHookOverheadTraceFunction-opcache

🟥 execution_time [+108.108µs; +115.612µs] or [+64.520%; +68.999%]

scenario:HookBench/benchHookOverheadTraceMethod

🟥 execution_time [+106.119µs; +119.037µs] or [+49.780%; +55.840%]

scenario:HookBench/benchHookOverheadTraceMethod-opcache

🟥 execution_time [+103.690µs; +108.288µs] or [+58.737%; +61.342%]

scenario:LaravelBench/benchLaravelDdprof

🟥 mem_peak [+140.060KB; +143.552KB] or [+2.736%; +2.804%]
🟩 execution_time [-909.591µs; -325.129µs] or [-7.205%; -2.576%]

scenario:LaravelBench/benchLaravelDdprof-opcache

🟩 execution_time [-525.377µs; -408.823µs] or [-4.243%; -3.302%]

scenario:LaravelBench/benchLaravelOverhead

🟩 execution_time [-541.254µs; -338.206µs] or [-4.744%; -2.964%]

scenario:LaravelBench/benchLaravelOverhead-opcache

🟩 execution_time [-800.830µs; -269.610µs] or [-6.895%; -2.321%]

scenario:LogsInjectionBench/benchLogsInfoInjection

🟩 execution_time [-5.497µs; -5.367µs] or [-82.452%; -80.500%]

scenario:LogsInjectionBench/benchLogsInfoInjection-opcache

🟩 execution_time [-7.126µs; -6.902µs] or [-80.682%; -78.141%]

scenario:LogsInjectionBench/benchLogsNullBaseline-opcache

🟥 execution_time [+859.156ns; +1046.844ns] or [+4.154%; +5.062%]

scenario:LogsInjectionBench/benchLogsNullInjection

🟥 execution_time [+1.074µs; +1.898µs] or [+2.072%; +3.662%]

scenario:LogsInjectionBench/benchLogsNullInjection-opcache

🟥 execution_time [+681.740ns; +1018.260ns] or [+3.285%; +4.906%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟩 execution_time [-6.375µs; -5.185µs] or [-6.021%; -4.898%]

scenario:PDOBench/benchPDOOverhead

🟩 execution_time [-204.812µs; -201.601µs] or [-77.210%; -76.000%]

scenario:PDOBench/benchPDOOverhead-opcache

🟩 execution_time [-201.684µs; -198.460µs] or [-77.023%; -75.792%]

scenario:PDOBench/benchPDOOverheadWithDBM

🟩 execution_time [-204.601µs; -201.187µs] or [-77.224%; -75.936%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

🟩 execution_time [-202.754µs; -199.637µs] or [-77.140%; -75.954%]

scenario:PHPRedisBench/benchRedisOverhead

🟩 execution_time [-939.708µs; -924.511µs] or [-87.755%; -86.336%]
🟩 mem_peak [-718.720KB; -718.720KB] or [-14.878%; -14.878%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

🟩 execution_time [-979.689µs; -949.157µs] or [-88.466%; -85.709%]
🟩 mem_peak [-345.400KB; -345.400KB] or [-14.349%; -14.349%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1-opcache

🟥 execution_time [+85.906ns; +144.094ns] or [+6.512%; +10.923%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

🟥 execution_time [+5.908µs; +5.993µs] or [+466.812%; +473.474%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

🟥 execution_time [+5.933µs; +6.047µs] or [+475.563%; +484.697%]

scenario:SpanBench/benchOpenTelemetryAPI

🟥 mem_peak [+1.339MB; +1.339MB] or [+3.113%; +3.113%]

scenario:SpanBench/benchOpenTelemetryAPI-opcache

🟥 mem_peak [+2.660MB; +2.665MB] or [+6.916%; +6.929%]

scenario:SymfonyBench/benchSymfonyDdprof

🟥 mem_peak [+146.667KB; +172.683KB] or [+2.853%; +3.359%]
🟩 execution_time [-869.667µs; -743.293µs] or [-10.438%; -8.922%]

scenario:SymfonyBench/benchSymfonyDdprof-opcache

🟩 execution_time [-823.374µs; -709.506µs] or [-9.954%; -8.578%]

scenario:SymfonyBench/benchSymfonyOverhead

🟩 execution_time [-811.615µs; -730.665µs] or [-10.475%; -9.431%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

🟩 execution_time [-937.141µs; -872.159µs] or [-11.886%; -11.062%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead

🟥 execution_time [+107.626µs; +111.928µs] or [+50.480%; +52.498%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache

🟥 execution_time [+107.857µs; +115.981µs] or [+60.294%; +64.835%]

scenario:TraceSerializationBench/benchSerializeTrace

🟩 execution_time [-40.786µs; -29.114µs] or [-9.236%; -6.593%]

scenario:WordPressBench/benchWordPressDdprof

🟩 execution_time [-3.911ms; -3.734ms] or [-13.396%; -12.789%]

scenario:WordPressBench/benchWordPressDdprof-opcache

🟩 execution_time [-3.794ms; -3.640ms] or [-13.034%; -12.506%]

scenario:WordPressBench/benchWordPressOverhead

🟩 execution_time [-3.708ms; -3.501ms] or [-13.689%; -12.925%]

scenario:WordPressBench/benchWordPressOverhead-opcache

🟩 execution_time [-3.862ms; -3.673ms] or [-14.185%; -13.491%]

estringana · 2025-09-29T10:11:44Z

appsec/tests/extension/add_endpoints.phpt

@@ -0,0 +1,13 @@
+--TEST--


Ignore this file

estringana · 2025-09-29T10:12:12Z

components-rs/crashtracker.h




+typedef enum  ddog_crasht_CrashInfoBuilder_NewResult_Tag {


This file got autogenerated

estringana · 2025-09-29T10:16:15Z

Cargo.lock

 "backtrace",
 "blazesym",
 "cc",
- "cc_utils",


This got removed automatically. Not sure why

estringana · 2025-09-29T12:48:08Z

src/DDTrace/Integrations/Laravel/LaravelIntegration.php

             }
        );

+        if (!\DDTrace\are_endpoints_collected()) {


This will be adapted. Just an idea of how it will be used

Co-authored-by: Gustavo Lopes <[email protected]>

estringana force-pushed the estringana/collect-framework-endpoints branch from 96601ba to 791f8e7 Compare August 27, 2025 10:38

estringana commented Sep 29, 2025

View reviewed changes

appsec/tests/extension/add_endpoints.phpt

@@ -0,0 +1,13 @@

--TEST--

Copy link

Contributor Author

estringana Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this file

estringana commented Sep 29, 2025

View reviewed changes

Cargo.lock

"backtrace",

"blazesym",

"cc",

"cc_utils",

Copy link

Contributor Author

estringana Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got removed automatically. Not sure why

estringana commented Sep 29, 2025

View reviewed changes

estringana force-pushed the estringana/collect-framework-endpoints branch from f5413d6 to e1212be Compare October 6, 2025 08:39

cataphract force-pushed the estringana/collect-framework-endpoints branch from 1a9903d to e1212be Compare October 10, 2025 09:55

estringana and others added 21 commits October 17, 2025 15:07

Add new function to add endpoint

07761e2

Aproaching solution

c4ad38f

Use shared cache instead of local

e4b4b79

wip

383f9c2

Used last push endpoints

778b4e3

Tests passing

27e01e1

Fix rebase errors

ee88a15

wip

d867b79

Update generated files

935ff05

Make string vectors work

9b08913

wip

e42697a

Add i32 vector

4ddfd2d

Add authentication vector

1c1bbf0

Add serde json

2e824df

Remove debugging lines

ccfaced

Replace char_c for slices

0804602

Amend PR comments

899d2c4

Strip invalid utf8 chars

db64aa0

Send Laravel endpoints

03899c2

Point to latest

8ad298b

Fix add-routes-collection (#3446)

9930fdc

Co-authored-by: Gustavo Lopes <[email protected]>

estringana added 4 commits October 17, 2025 15:09

Point to latest libdatadog

575d278

Remove response_code

d0b4f89

Remove non used fields

bc2f0e5

Point to latest

db596ad

estringana force-pushed the estringana/collect-framework-endpoints branch from 086f86d to db596ad Compare October 17, 2025 13:10

estringana added 4 commits October 17, 2025 15:17

Generate cbindgen

3336b2e

Point to latest

bddbfdb

Point to latest

a3b4ba1

Point to the latest

4deea57

estringana force-pushed the estringana/collect-framework-endpoints branch from e5a8967 to 4deea57 Compare October 20, 2025 10:43

estringana added 3 commits October 20, 2025 13:20

Point to latest

04332f1

Test Laravel integration

1347c7c

Refactor telemetry collection on appsec integration tests

e2c597b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new function to add endpoint #3381

Add new function to add endpoint #3381

estringana commented Aug 18, 2025

Uh oh!

codecov-commenter commented Aug 25, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 25, 2025 •

edited

Loading

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add new function to add endpoint #3381

Are you sure you want to change the base?

Add new function to add endpoint #3381

Conversation

estringana commented Aug 18, 2025

Description

Reviewer checklist

Uh oh!

codecov-commenter commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

scenario:ContextPropagationBench/benchExtractHeaders128Bit

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

scenario:EmptyFileBench/benchEmptyFileDdprof

scenario:HookBench/benchHookOverheadInstallHookOnFunction

scenario:HookBench/benchHookOverheadInstallHookOnFunction-opcache

scenario:HookBench/benchHookOverheadInstallHookOnMethod

scenario:HookBench/benchHookOverheadInstallHookOnMethod-opcache

scenario:HookBench/benchHookOverheadTraceFunction

scenario:HookBench/benchHookOverheadTraceFunction-opcache

scenario:HookBench/benchHookOverheadTraceMethod

scenario:HookBench/benchHookOverheadTraceMethod-opcache

scenario:LaravelBench/benchLaravelDdprof

scenario:LaravelBench/benchLaravelDdprof-opcache

scenario:LaravelBench/benchLaravelOverhead

scenario:LaravelBench/benchLaravelOverhead-opcache

scenario:LogsInjectionBench/benchLogsInfoInjection

scenario:LogsInjectionBench/benchLogsInfoInjection-opcache

scenario:LogsInjectionBench/benchLogsNullBaseline-opcache

scenario:LogsInjectionBench/benchLogsNullInjection

scenario:LogsInjectionBench/benchLogsNullInjection-opcache

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

scenario:PDOBench/benchPDOOverhead

scenario:PDOBench/benchPDOOverhead-opcache

scenario:PDOBench/benchPDOOverheadWithDBM

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

scenario:PHPRedisBench/benchRedisOverhead

scenario:PHPRedisBench/benchRedisOverhead-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching1-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

scenario:SpanBench/benchOpenTelemetryAPI

scenario:SpanBench/benchOpenTelemetryAPI-opcache

scenario:SymfonyBench/benchSymfonyDdprof

scenario:SymfonyBench/benchSymfonyDdprof-opcache

scenario:SymfonyBench/benchSymfonyOverhead

scenario:SymfonyBench/benchSymfonyOverhead-opcache

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache

scenario:TraceSerializationBench/benchSerializeTrace

scenario:WordPressBench/benchWordPressDdprof

scenario:WordPressBench/benchWordPressDdprof-opcache

scenario:WordPressBench/benchWordPressOverhead

scenario:WordPressBench/benchWordPressOverhead-opcache

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov-commenter commented Aug 25, 2025 •

edited

Loading

pr-commenter bot commented Aug 25, 2025 •

edited

Loading