Add new function to add endpoint #3381

estringana · 2025-08-18T13:17:14Z

Description

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

codecov-commenter · 2025-08-25T16:08:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.13%. Comparing base (1fa51af) to head (1964483).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
- Coverage   62.19%   62.13%   -0.06%     
==========================================
  Files         141      141              
  Lines       12622    12622              
  Branches     1650     1650              
==========================================
- Hits         7850     7843       -7     
- Misses       4045     4053       +8     
+ Partials      727      726       -1

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa51af...1964483. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2025-08-25T16:40:00Z

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-22 11:54:36

Comparing candidate commit 825104a in PR branch estringana/collect-framework-endpoints with baseline commit 1fa51af in branch master.

Found 9 performance improvements and 6 performance regressions! Performance is the same for 179 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

🟥 execution_time [+1.138µs; +2.062µs] or [+11.049%; +20.019%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

🟩 execution_time [-4.306µs; -3.214µs] or [-4.063%; -3.032%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟩 execution_time [-6.440µs; -5.440µs] or [-6.068%; -5.126%]

scenario:PDOBench/benchPDOOverhead

🟩 execution_time [-61.300µs; -56.250µs] or [-23.042%; -21.144%]

scenario:PDOBench/benchPDOOverhead-opcache

🟩 execution_time [-61.405µs; -57.202µs] or [-23.377%; -21.777%]

scenario:PDOBench/benchPDOOverheadWithDBM

🟩 execution_time [-63.298µs; -58.044µs] or [-23.684%; -21.718%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

🟩 execution_time [-61.739µs; -57.501µs] or [-23.423%; -21.816%]

scenario:PHPRedisBench/benchRedisOverhead

🟩 execution_time [-312.222µs; -283.358µs] or [-29.061%; -26.374%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

🟩 execution_time [-307.735µs; -278.894µs] or [-28.047%; -25.419%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

🟥 execution_time [+91.798ns; +131.602ns] or [+7.956%; +11.406%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

🟥 execution_time [+96.491ns; +157.109ns] or [+8.287%; +13.494%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

🟥 execution_time [+113.668ns; +165.932ns] or [+9.710%; +14.175%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

🟥 execution_time [+69.435ns; +124.565ns] or [+5.896%; +10.577%]

scenario:SpanBench/benchOpenTelemetryAPI

🟥 mem_peak [+1.720MB; +1.723MB] or [+4.164%; +4.171%]

scenario:TraceSerializationBench/benchSerializeTrace

🟩 execution_time [-33.853µs; -21.347µs] or [-7.707%; -4.860%]

estringana · 2025-09-29T10:11:44Z

appsec/tests/extension/add_endpoints.phpt

@@ -0,0 +1,13 @@
+--TEST--


Ignore this file

estringana · 2025-09-29T10:12:12Z

components-rs/crashtracker.h




+typedef enum  ddog_crasht_CrashInfoBuilder_NewResult_Tag {


This file got autogenerated

estringana · 2025-09-29T10:16:15Z

Cargo.lock

 "backtrace",
 "blazesym",
 "cc",
- "cc_utils",


This got removed automatically. Not sure why

estringana · 2025-09-29T12:48:08Z

src/DDTrace/Integrations/Laravel/LaravelIntegration.php

             }
        );

+        if (!\DDTrace\are_endpoints_collected()) {


This will be adapted. Just an idea of how it will be used

Co-authored-by: Gustavo Lopes <[email protected]>

estringana force-pushed the estringana/collect-framework-endpoints branch from 96601ba to 791f8e7 Compare August 27, 2025 10:38

estringana commented Sep 29, 2025

View reviewed changes

appsec/tests/extension/add_endpoints.phpt Outdated

@@ -0,0 +1,13 @@

--TEST--

Copy link

Contributor Author

estringana Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this file

estringana commented Sep 29, 2025

View reviewed changes

Cargo.lock

"backtrace",

"blazesym",

"cc",

"cc_utils",

Copy link

Contributor Author

estringana Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got removed automatically. Not sure why

estringana commented Sep 29, 2025

View reviewed changes

estringana force-pushed the estringana/collect-framework-endpoints branch from f5413d6 to e1212be Compare October 6, 2025 08:39

cataphract force-pushed the estringana/collect-framework-endpoints branch from 1a9903d to e1212be Compare October 10, 2025 09:55

estringana force-pushed the estringana/collect-framework-endpoints branch 2 times, most recently from e5a8967 to 4deea57 Compare October 20, 2025 10:43

estringana added 19 commits October 21, 2025 17:22

Add new function to add endpoint

5efc50c

Aproaching solution

314df92

Use shared cache instead of local

1a621d1

wip

b9d0f1b

Used last push endpoints

de543ad

Tests passing

205c68e

Fix rebase errors

0c6e73c

wip

97dabd1

Update generated files

fdeb3cd

Make string vectors work

8b58d11

wip

7086cfd

Add i32 vector

fb4fc56

Add authentication vector

1526a3c

Add serde json

9fb1ce2

Remove debugging lines

a728897

Replace char_c for slices

1c12aec

Amend PR comments

8e0a9d6

Strip invalid utf8 chars

ceb48de

Send Laravel endpoints

00ef539

estringana and others added 10 commits October 21, 2025 17:22

Point to latest

90b5bec

Fix add-routes-collection (#3446)

843ff5f

Co-authored-by: Gustavo Lopes <[email protected]>

Point to latest libdatadog

9e48c84

Remove response_code

d2665ba

Remove non used fields

1c491e6

Point to latest

eead0d7

Generate cbindgen

ef1561e

Test Laravel integration

3db5e4e

Refactor telemetry collection on appsec integration tests

a754d27

Point to latest

b66e5b7

estringana force-pushed the estringana/collect-framework-endpoints branch from e2c597b to b66e5b7 Compare October 21, 2025 15:25

estringana added 7 commits October 21, 2025 17:26

Remove non necessary file

689da43

Update php stub

0161972

Generate common

1133abb

Amend laravel compatibility

fa3efdf

Revert non required changes

abed26c

Play defensive on Laravel Integration

825104a

Get routes from Symfony

1964483

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new function to add endpoint #3381

Add new function to add endpoint #3381

estringana commented Aug 18, 2025

Uh oh!

codecov-commenter commented Aug 25, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 25, 2025 •

edited

Loading

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add new function to add endpoint #3381

Are you sure you want to change the base?

Add new function to add endpoint #3381

Conversation

estringana commented Aug 18, 2025

Description

Reviewer checklist

Uh oh!

codecov-commenter commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

scenario:ComposerTelemetryBench/benchTelemetryParsing

scenario:MessagePackSerializationBench/benchMessagePackSerialization

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

scenario:PDOBench/benchPDOOverhead

scenario:PDOBench/benchPDOOverhead-opcache

scenario:PDOBench/benchPDOOverheadWithDBM

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

scenario:PHPRedisBench/benchRedisOverhead

scenario:PHPRedisBench/benchRedisOverhead-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching1

scenario:SamplingRuleMatchingBench/benchRegexMatching2

scenario:SamplingRuleMatchingBench/benchRegexMatching3

scenario:SamplingRuleMatchingBench/benchRegexMatching4

scenario:SpanBench/benchOpenTelemetryAPI

scenario:TraceSerializationBench/benchSerializeTrace

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov-commenter commented Aug 25, 2025 •

edited

Loading

pr-commenter bot commented Aug 25, 2025 •

edited

Loading