Skip to content

Conversation

Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Sep 2, 2025

Description

Support PHP 8.5 for the Tracer, Appsec and the profiler.

Note: This version of PHP is meant to be released on November 20th.
Note2: The remaining failing tests are fixed via this PR and will be release with the 0RC3 version of PHP 8.5. This PR will be merged once it is released.

@pr-commenter
Copy link

pr-commenter bot commented Sep 2, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-10 12:51:13

Comparing candidate commit 9c50248 in PR branch leiyks/php-8.5 with baseline commit 9298487 in branch master.

Found 1 performance improvements and 6 performance regressions! Performance is the same for 185 metrics, 2 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.355µs; +4.325µs] or [+3.167%; +4.084%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+61.570ns; +125.630ns] or [+5.202%; +10.615%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+92.576ns; +158.424ns] or [+7.950%; +13.604%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+52.720ns; +120.480ns] or [+4.427%; +10.117%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+98.329ns; +172.671ns] or [+8.415%; +14.777%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 mem_peak [+1.717MB; +1.721MB] or [+4.157%; +4.168%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-28.242µs; -14.658µs] or [-6.400%; -3.322%]

@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 3 times, most recently from c3d6bb6 to 76324f3 Compare September 8, 2025 14:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.74%. Comparing base (9298487) to head (9c50248).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3400      +/-   ##
==========================================
- Coverage   61.89%   61.74%   -0.15%     
==========================================
  Files         141      141              
  Lines       12501    12501              
  Branches     1633     1633              
==========================================
- Hits         7737     7719      -18     
- Misses       4042     4059      +17     
- Partials      722      723       +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9298487...9c50248. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 7 times, most recently from b6000bf to 7d6345a Compare September 17, 2025 15:34
@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 5 times, most recently from 0aff6bc to 2bc1c1d Compare September 29, 2025 15:53
@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-10-10 11:59:59

Comparing candidate commit 9c50248 in PR branch leiyks/php-8.5 with baseline commit 9298487 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@realFlowControl realFlowControl force-pushed the leiyks/php-8.5 branch 2 times, most recently from e248dc5 to c2d5d7b Compare October 1, 2025 11:58
@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 6 times, most recently from 03e8d05 to 0f2a191 Compare October 6, 2025 14:58
Leiyks added 3 commits October 6, 2025 17:07
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Leiyks and others added 12 commits October 6, 2025 17:07
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
CentOS 7's glibc lacks __builtin_cpu_init() support, causing IFUNC
resolvers to crash during dynamic linking when detecting AVX2 support.
Disable IFUNC and use runtime function pointer initialization instead.
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks Leiyks force-pushed the leiyks/php-8.5 branch 9 times, most recently from fc24183 to 75aa61e Compare October 8, 2025 14:58
Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks Leiyks marked this pull request as ready for review October 10, 2025 11:45
@Leiyks Leiyks requested review from a team as code owners October 10, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants