chore(prof) cleanup I/O profiling code #3406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realFlowControl
force-pushed
the
florian/cleanup
branch
from
69fccab to
83a4fe4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3406 +/- ##
==========================================
- Coverage 61.89% 61.86% -0.03%
==========================================
Files 141 141
Lines 12501 12501
Branches 1633 1633
==========================================
- Hits 7737 7734 -3
- Misses 4042 4045 +3
Partials 722 722 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2025-10-15 11:34:15 Comparing candidate commit 77a818c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
realFlowControl
force-pushed
the
florian/cleanup
branch
from
83a4fe4 to
7dab3a0
Compare
Reduces CPU overhead by checking stable_config availability once before the main loop instead of on every config entry/name iteration. This eliminates hundreds of redundant NULL checks per request. Adds zai_config_stable_file_is_available() to avoid repeated function calls and NULL checks inside the hot loop. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Restructured conditional chains to separate strcpy side effects from boolean checks. This improves code clarity and makes the control flow more explicit. The strcpy is now only executed after the source type check passes, maintaining the same performance characteristics while improving maintainability. Changed from chained && expressions with strcpy side effects to nested if statements with clear separation of concerns. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds an early continue for config entries that have names_count == 0, avoiding unnecessary processing and conditional checks for entries that cannot have any configuration values. This reduces loop overhead by skipping empty entries entirely instead of entering the inner loop and immediately exiting. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Modified zai_config_process_runtime_env to accept a length parameter instead of calling strlen(buf.ptr) for every config value. When we copy from zend_string sources, we now use ZSTR_LEN to get the length directly, eliminating redundant strlen calls on every iteration. This optimization is particularly effective for the stable config paths (FLEET and LOCAL) where we already have the string length from the zend_string structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Benchmarks [ tracer ]Benchmark execution time: 2025-10-15 12:25:59 Comparing candidate commit 77a818c in PR branch Found 1 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All this PR does is extract the global offset table manipulation code into it's own file
Reviewer checklist