Skip to content

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 2, 2025

Other cases are covered, but specifically local variables of exception replay stack frames were not redacted automatically.

@bwoebi bwoebi requested a review from a team as a code owner October 2, 2025 17:10
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.75%. Comparing base (6bdf05a) to head (5091cdf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3440      +/-   ##
==========================================
- Coverage   61.87%   61.75%   -0.13%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
- Hits         7723     7708      -15     
- Misses       4038     4051      +13     
- Partials      720      722       +2     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdf05a...5091cdf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-02 18:13:59

Comparing candidate commit 5091cdf in PR branch bob/redact-exception-replay-locals with baseline commit 6bdf05a in branch master.

Found 1 performance improvements and 5 performance regressions! Performance is the same for 186 metrics, 2 unstable metrics.

scenario:BM_TeaSapiSpindown

  • 🟥 execution_time [+15.621µs; +33.593µs] or [+2.973%; +6.394%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+43.169ns; +99.431ns] or [+3.584%; +8.255%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+69.569ns; +132.431ns] or [+5.936%; +11.301%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+96.694ns; +144.306ns] or [+8.295%; +12.379%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+48.249ns; +120.551ns] or [+4.082%; +10.200%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-28.641µs; -18.059µs] or [-6.433%; -4.056%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants