Skip to content

Conversation

morrisonlevi
Copy link
Collaborator

Description

This is a proof-of-concept to see how the libdatadog changes affect a profiling library.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi added ☠️ do-not-merge/WIP profiling Relates to the Continuous Profiler labels Oct 18, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.13%. Comparing base (3456dec) to head (b3e23b2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3457      +/-   ##
==========================================
- Coverage   62.15%   62.13%   -0.02%     
==========================================
  Files         141      141              
  Lines       12622    12622              
  Branches     1650     1650              
==========================================
- Hits         7845     7843       -2     
- Misses       4050     4053       +3     
+ Partials      727      726       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3456dec...b3e23b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 18, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-10-18 20:54:04

Comparing candidate commit b3e23b2 in PR branch PROF-11832-Add-zstd-to-compression-configuration-to-libdatadog with baseline commit 3456dec in branch master.

Found 2 performance improvements and 4 performance regressions! Performance is the same for 23 metrics, 7 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟥 cpu_system_time [+109.863ms; +149.609ms] or [+26.801%; +36.498%]
  • 🟥 cpu_usage_percentage [+5.019%; +6.524%]
  • 🟥 cpu_user_time [+161.635ms; +216.551ms] or [+11.507%; +15.417%]
  • 🟥 execution_time [+145.204ms; +157.447ms] or [+12.984%; +14.079%]

scenario:walk_stack/50

  • 🟩 wall_time [-736.726ns; -726.570ns] or [-4.566%; -4.503%]

scenario:walk_stack/99

  • 🟩 wall_time [-879.736ns; -873.925ns] or [-5.444%; -5.408%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☠️ do-not-merge/WIP profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants