Skip to content

Appsec: use abstract namespace on linux#3525

Merged
cataphract merged 8 commits intomasterfrom
glopes/appsec-abstract-ns
Dec 24, 2025
Merged

Appsec: use abstract namespace on linux#3525
cataphract merged 8 commits intomasterfrom
glopes/appsec-abstract-ns

Conversation

@cataphract
Copy link
Contributor

Description

Create sockets in the abstract namespace by default (on linux). In this case there will be no file lock.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner December 9, 2025 18:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.64%. Comparing base (560e003) to head (72f5047).

Files with missing lines Patch % Lines
appsec/src/helper/network/acceptor.cpp 0.00% 43 Missing ⚠️
appsec/src/extension/network.c 40.90% 10 Missing and 3 partials ⚠️
appsec/src/helper/config.hpp 0.00% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (12.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3525      +/-   ##
==========================================
- Coverage   61.74%   61.64%   -0.11%     
==========================================
  Files         143      139       -4     
  Lines       13045    13051       +6     
  Branches     1704     1712       +8     
==========================================
- Hits         8055     8045      -10     
- Misses       4228     4241      +13     
- Partials      762      765       +3     
Files with missing lines Coverage Δ
appsec/src/extension/configuration.h 100.00% <ø> (ø)
appsec/src/extension/helper_process.c 52.75% <ø> (ø)
appsec/src/helper/config.hpp 63.15% <0.00%> (-36.85%) ⬇️
appsec/src/extension/network.c 41.49% <40.90%> (-1.75%) ⬇️
appsec/src/helper/network/acceptor.cpp 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 560e003...72f5047. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-12-24 13:03:34

Comparing candidate commit 72f5047 in PR branch glopes/appsec-abstract-ns with baseline commit 560e003 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-12-12 19:54:52

Comparing candidate commit 50f6207 in PR branch glopes/appsec-abstract-ns with baseline commit 14dc0a4 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 190 metrics, 1 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-1338.261ns; -461.739ns] or [-12.056%; -4.160%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.460µs; +4.020µs] or [+3.409%; +3.960%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+6.107µs; +7.073µs] or [+5.855%; +6.782%]

@cataphract cataphract force-pushed the glopes/appsec-abstract-ns branch 2 times, most recently from 4c56cbb to 23bd2ab Compare December 11, 2025 12:17
@cataphract cataphract force-pushed the glopes/appsec-abstract-ns branch from 23bd2ab to 6455a6d Compare December 11, 2025 12:35
@cataphract cataphract force-pushed the glopes/appsec-abstract-ns branch from 78c49b9 to cc1cf82 Compare December 11, 2025 20:57
@cataphract cataphract requested a review from a team as a code owner December 12, 2025 18:50
@cataphract cataphract merged commit 575faf4 into master Dec 24, 2025
2002 of 2008 checks passed
@cataphract cataphract deleted the glopes/appsec-abstract-ns branch December 24, 2025 13:27
@github-actions github-actions bot added this to the 1.16.0 milestone Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants