fix: avoid curl_getenv for unix:// too#3540
Merged
morrisonlevi merged 1 commit intomasterfrom Dec 19, 2025
Merged
Conversation
realFlowControl
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #3528 which went out in v1.15.0, we avoided some calls to
curl_getenvby adjusting proxy environment variables. However, there was a case it didn't consider: using Unix Domain Sockets (UDS) to talk to the agent. For UDS, we rewrote the URL to be HTTP after we set the proxy config, so when a customer uses UDS, it would still check for proxy envs. Now UDS is handled before we do the proxy config.Like the previous PR, I verified this with a
LD_PRELOADwrapper forgetenvand looking at the order of the calls. On 1.15.x, a call togetenvforno_proxywas made when using UDS, and with this branch, it's gone.Reviewer checklist