-
Notifications
You must be signed in to change notification settings - Fork 167
Adds process_tags to the first span of each tracing payload #3566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: PROFeNoM <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
- Coverage 62.02% 61.93% -0.10%
==========================================
Files 140 140
Lines 13309 13309
Branches 1762 1762
==========================================
- Hits 8255 8243 -12
- Misses 4265 4275 +10
- Partials 789 791 +2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e6cb061 to
3a8038c
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-01-19 10:28:35 Comparing candidate commit 89c75b2 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
|
70d937f to
7c56e32
Compare
Signed-off-by: Bob Weinand <[email protected]>
9a986b3 to
67e08df
Compare
bwoebi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
Description
This PR implements this RFC for the tracing product.
Add process_tags in APM payload. According to the RFC, the tag
_dd.tags.processis set in the first first span of each payload.The set tag are:
entrypoint.workdir. The working dir name, should be the last path segment.entrypoint.name. The entrypoint of the application. It is the the script name. Set to none if php is executed as an executable.entrypoint.type. Eitherscriptorexecutableentrypoint.basedir. The base dir is the directory where the called executable resides. Should be the last path segment.runtime.sapi. The name of the SAPI in which PHP is run.Reviewer checklist