Skip to content

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 12, 2026

Description

This PR implements this RFC for the tracing product.

Add process_tags in APM payload. According to the RFC, the tag _dd.tags.process is set in the first first span of each payload.

The set tag are:

  • entrypoint.workdir. The working dir name, should be the last path segment.
  • entrypoint.name. The entrypoint of the application. It is the the script name. Set to none if php is executed as an executable.
  • entrypoint.type. Either script or executable
  • entrypoint.basedir. The base dir is the directory where the called executable resides. Should be the last path segment.
  • runtime.sapi. The name of the SAPI in which PHP is run.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 12, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696dfa6000000000493e52fa657a584f
tid: 696dfa6000000000
hexProcessTraceId: 493e52fa657a584f
hexProcessSpanId: 3708a31acc33f4b0
processTraceId: 5277747048722618447
processSpanId: 3965598807390155952

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 89c75b2 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.93%. Comparing base (1316514) to head (89c75b2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
- Coverage   62.02%   61.93%   -0.10%     
==========================================
  Files         140      140              
  Lines       13309    13309              
  Branches     1762     1762              
==========================================
- Hits         8255     8243      -12     
- Misses       4265     4275      +10     
- Partials      789      791       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1316514...89c75b2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubloom dubloom changed the title Dubloom/process tags feat(process_tags): add process_tags to tracing payloads Jan 12, 2026
@dubloom dubloom marked this pull request as ready for review January 12, 2026 13:23
@dubloom dubloom requested review from a team as code owners January 12, 2026 13:23
@dubloom dubloom force-pushed the dubloom/process-tags branch from e6cb061 to 3a8038c Compare January 13, 2026 15:58
@dubloom dubloom requested a review from bwoebi January 13, 2026 16:27
@dubloom dubloom changed the title feat(process_tags): add process_tags to tracing payloads Adds process_tags to the first span of each tracing payload Jan 15, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-19 10:28:35

Comparing candidate commit 89c75b2 in PR branch dubloom/process-tags with baseline commit 1316514 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-1297.555ns; -302.445ns] or [-10.059%; -2.345%]

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.962µs; -0.838µs] or [-15.209%; -6.496%]

@dubloom dubloom force-pushed the dubloom/process-tags branch from 70d937f to 7c56e32 Compare January 16, 2026 09:51
@bwoebi bwoebi force-pushed the dubloom/process-tags branch from 9a986b3 to 67e08df Compare January 16, 2026 15:09
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@dubloom dubloom merged commit 434d817 into master Jan 19, 2026
2003 of 2008 checks passed
@dubloom dubloom deleted the dubloom/process-tags branch January 19, 2026 12:07
@github-actions github-actions bot added this to the 1.16.0 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants