-
Notifications
You must be signed in to change notification settings - Fork 167
ci(prof): Add frameless function call to validate stack walking #3584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8d918e7 to
844fc7d
Compare
|
844fc7d to
548c474
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3584 +/- ##
==========================================
- Coverage 62.01% 61.92% -0.10%
==========================================
Files 140 140
Lines 13309 13309
Branches 1762 1762
==========================================
- Hits 8253 8241 -12
- Misses 4268 4278 +10
- Partials 788 790 +2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
9089209 to
7b87e73
Compare
Benchmarks [ profiler ]Benchmark execution time: 2026-01-20 15:20:58 Comparing candidate commit a418d97 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
7b87e73 to
19065de
Compare
228ba5d to
a418d97
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-01-20 16:12:23 Comparing candidate commit a418d97 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PHPRedisBench/benchRedisOverhead
|
morrisonlevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and thank you for looking into this! It's so nice to come back from vacation and have a blocker removed for me ❤️
Description
This PR adds a frameless function call to the allocation profiling correctness test, mainly to make sure that frameless function show up in allocation profiles in a correct way because we had a problem with that in #3559
Also this PR removes the
valuesbecause they are per second values and will be upscaled to whatever the profiling period was. This makes it dependent on the hardware ... It basically says: we can allocate x bytes per second, which makes me wonder why this was so stable after all 😉I guess going forward we should have tests that measure the actual size in bytes, and it seems we gonna get a phpt one from @morrisonlevi with another PR.
Reviewer checklist