Skip to content

Conversation

@realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Jan 20, 2026

Description

This PR adds a frameless function call to the allocation profiling correctness test, mainly to make sure that frameless function show up in allocation profiles in a correct way because we had a problem with that in #3559

Also this PR removes the values because they are per second values and will be upscaled to whatever the profiling period was. This makes it dependent on the hardware ... It basically says: we can allocate x bytes per second, which makes me wonder why this was so stable after all 😉

I guess going forward we should have tests that measure the actual size in bytes, and it seems we gonna get a phpt one from @morrisonlevi with another PR.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Jan 20, 2026
@realFlowControl realFlowControl force-pushed the florian/frameless-functions-correctness branch from 8d918e7 to 844fc7d Compare January 20, 2026 11:15
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 20, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1024 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696fabd00000000002d10b677ee11b13
tid: 696fabd000000000
hexProcessTraceId: 02d10b677ee11b13
hexProcessSpanId: 045f4d40bd182713
processTraceId: 202955997346601747
processSpanId: 315055439384946451

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a418d97 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@realFlowControl realFlowControl changed the title Add frameless function call to validate stack walking ci(prof): Add frameless function call to validate stack walking Jan 20, 2026
@realFlowControl realFlowControl force-pushed the florian/frameless-functions-correctness branch from 844fc7d to 548c474 Compare January 20, 2026 11:23
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.92%. Comparing base (617ba06) to head (a418d97).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3584      +/-   ##
==========================================
- Coverage   62.01%   61.92%   -0.10%     
==========================================
  Files         140      140              
  Lines       13309    13309              
  Branches     1762     1762              
==========================================
- Hits         8253     8241      -12     
- Misses       4268     4278      +10     
- Partials      788      790       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617ba06...a418d97. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@realFlowControl realFlowControl force-pushed the florian/frameless-functions-correctness branch 3 times, most recently from 9089209 to 7b87e73 Compare January 20, 2026 11:52
@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-20 15:20:58

Comparing candidate commit a418d97 in PR branch florian/frameless-functions-correctness with baseline commit 617ba06 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@realFlowControl realFlowControl force-pushed the florian/frameless-functions-correctness branch from 228ba5d to a418d97 Compare January 20, 2026 15:04
@realFlowControl realFlowControl marked this pull request as ready for review January 20, 2026 15:09
@realFlowControl realFlowControl requested review from a team as code owners January 20, 2026 15:09
@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-01-20 16:12:23

Comparing candidate commit a418d97 in PR branch florian/frameless-functions-correctness with baseline commit 617ba06 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+6.485µs; +7.815µs] or [+6.000%; +7.231%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+9.198µs; +11.082µs] or [+8.943%; +10.775%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+22.298µs; +59.635µs] or [+2.589%; +6.925%]

Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thank you for looking into this! It's so nice to come back from vacation and have a blocker removed for me ❤️

@morrisonlevi morrisonlevi merged commit bb3cb7c into master Jan 20, 2026
2003 of 2009 checks passed
@morrisonlevi morrisonlevi deleted the florian/frameless-functions-correctness branch January 20, 2026 17:03
@github-actions github-actions bot added this to the 1.17.0 milestone Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants