Skip to content

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Jan 21, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Signed-off-by: Alexandre Rulleau <[email protected]>
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 21, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

testDynamicRouteWithAllParametersGiven from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\PathParamsTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\PathParamsTest::testDynamicRouteWithAllParametersGiven
Failed asserting that 0 matches expected 1.

tests/Integrations/Laravel/PathParamsTestSuite.php:19
tests/Common/RetryTraitVersionGeneric.php:28
testDynamicRouteWithOptionalParametersNotGiven from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\PathParamsTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\PathParamsTest::testDynamicRouteWithOptionalParametersNotGiven
Failed asserting that 0 matches expected 1.

tests/Integrations/Laravel/PathParamsTestSuite.php:31
tests/Common/RetryTraitVersionGeneric.php:28

🧪 25 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6970e9c800000000b65891e38149b280
tid: 6970e9c800000000
hexProcessTraceId: b65891e38149b280
hexProcessSpanId: 5c0632dffd742505
processTraceId: 13139412319166116480
processSpanId: 6631043438960977157

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6970e9bb00000000d2974194a2950049
tid: 6970e9bb00000000
hexProcessTraceId: d2974194a2950049
hexProcessSpanId: c2c246cb0ca37d16
processTraceId: 15174669576086814793
processSpanId: 14033857226744233238
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5becc6e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.91%. Comparing base (16eaf8b) to head (5becc6e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
- Coverage   62.01%   61.91%   -0.11%     
==========================================
  Files         140      140              
  Lines       13312    13312              
  Branches     1762     1762              
==========================================
- Hits         8256     8242      -14     
- Misses       4267     4280      +13     
- Partials      789      790       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16eaf8b...5becc6e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Leiyks Leiyks closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants