Skip to content

Conversation

@estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 22, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 2063 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1a64d01 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@estringana estringana force-pushed the estringana/fix-installer-tests branch 2 times, most recently from c13f612 to 005538e Compare January 22, 2026 15:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.81%. Comparing base (4a26042) to head (1a64d01).
⚠️ Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   61.90%   61.81%   -0.10%     
==========================================
  Files         140      140              
  Lines       13281    13281              
  Branches     1758     1758              
==========================================
- Hits         8221     8209      -12     
- Misses       4272     4282      +10     
- Partials      788      790       +2     
Files with missing lines Coverage Δ
appsec/src/extension/configuration.h 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a26042...1a64d01. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@estringana estringana force-pushed the estringana/fix-installer-tests branch from 005538e to 1a64d01 Compare January 23, 2026 15:54
@estringana estringana marked this pull request as ready for review January 26, 2026 08:21
@estringana estringana requested a review from a team as a code owner January 26, 2026 08:21
@estringana estringana merged commit c4d4325 into master Jan 26, 2026
1997 of 2008 checks passed
@estringana estringana deleted the estringana/fix-installer-tests branch January 26, 2026 08:21
@github-actions github-actions bot added this to the 1.17.0 milestone Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants