refactor(profiling): extract Backtrace type by morrisonlevi · Pull Request #3612 · DataDog/dd-trace-php

morrisonlevi · 2026-01-31T03:12:43Z

Description

In a future change, this may hold a refcount for another object, so we need to encapsulate it. The plan is for holding a ProfilesDictionary and sending data from it.

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

In a future change, this may hold a refcount for another object, so we need to encapsulate it.

codecov-commenter · 2026-01-31T03:20:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.12%. Comparing base (e380043) to head (893a3b4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3612      +/-   ##
==========================================
- Coverage   62.21%   62.12%   -0.09%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8329     8317      -12     
- Misses       4260     4270      +10     
- Partials      798      800       +2

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e380043...893a3b4. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2026-01-31T03:25:40Z

Benchmarks [ profiler ]

Benchmark execution time: 2026-02-02 08:50:49

Comparing candidate commit 893a3b4 in PR branch levi/backtrace with baseline commit e380043 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 7 unstable metrics.

scenario:walk_stack/50

🟩 wall_time [-913.819ns; -903.438ns] or [-5.589%; -5.525%]

scenario:walk_stack/99

🟩 wall_time [-774.355ns; -769.748ns] or [-4.780%; -4.752%]

realFlowControl · 2026-02-02T08:45:07Z

The test_collect_stack_sample test was not executed, due to a wrong cfg attribute:

#[cfg(stack_walking_tests)]
// vs.
#[cfg(feature = "stack_walking_tests")]

I fixed that and also added a stub for the zend_flf_functions (with 893a3b4) which does not exist in the scope of cargo test --all-features as it gets executed in CI .

realFlowControl

Nice cleanup, I fixed the test not being executed and my open comment is a nit pick, feel free to merge.

realFlowControl · 2026-02-02T08:46:06Z

profiling/src/profiling/stack_walking.rs

-            assert_eq!(stack[0].function, "function name 003");
-            assert_eq!(stack[0].file, Some("filename-003.php".into()));
-            assert_eq!(stack[0].line, 0);
+            let frames = &stack;
+            assert_eq!(frames[0].function, "function name 003");
+            assert_eq!(frames[0].file, Some("filename-003.php".into()));
+            assert_eq!(frames[0].line, 0);

-            assert_eq!(stack[1].function, "function name 002");
-            assert_eq!(stack[1].file, Some("filename-002.php".into()));
-            assert_eq!(stack[1].line, 0);
+            assert_eq!(frames[1].function, "function name 002");
+            assert_eq!(frames[1].file, Some("filename-002.php".into()));
+            assert_eq!(frames[1].line, 0);

-            assert_eq!(stack[2].function, "function name 001");
-            assert_eq!(stack[2].file, Some("filename-001.php".into()));
-            assert_eq!(stack[2].line, 0);
+            assert_eq!(frames[2].function, "function name 001");
+            assert_eq!(frames[2].file, Some("filename-001.php".into()));
+            assert_eq!(frames[2].line, 0);


I think that because of the Deref implementation for Backtrace we might not need these changes, but technically it is fine either way.

morrisonlevi · 2026-02-02T15:32:19Z

Force merging because Florian's git commit is unverified. I have reviewed the commit, and it's all good!

* refactor(profiling): extract Backtrace type In a future change, this may hold a refcount for another object, so we need to encapsulate it. * fix `test_collect_stack_sample` not running --------- Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com>

* Adds process tags to profiler uploader * remove useless utils function * remove empty lines and fix spelling * add function to ddtrace.sym * feat(CI: installer tests): fix installer tests by changing enabling check on appsec extension (#3604) Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * refactor(profiling): use module globals for ZMM state (#3608) * refactor(profiling): use module globals for ZMM state * style: fix clippy warnings * Apply suggestions from code review Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com> * docs: note ZTS vs NTS differences --------- Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com> * refactor(profiling): extract Backtrace type (#3612) * refactor(profiling): extract Backtrace type In a future change, this may hold a refcount for another object, so we need to encapsulate it. * fix `test_collect_stack_sample` not running --------- Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com> * Propagate RELIABILITY_ENV_BRANCH to downstream pipeline (#3605) * Add simple_onboarding_appsec to SSI system tests (#3617) * Stores remote config requests in request-replayer (#3585) * feat(profiling): internal metrics for overhead (#3616) * feat(profiling): internal metrics for overhead * feat(profiling): move CPU time capture to include serialization for `ddprof_upload` for current profile exported Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(profiling): add CPU time tracking for `ddprof_time` thread Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(profiling): separate CPU time tracking per background thread Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix(tracing): hook is_internal was backwards (#3625) * Fix phpt asm standalone tests (#3628) * fix readme file links (#3610) * test(language-tests): properly skip online tests and disabled soap_qname_crash.phpt on all version (#3632) Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * Collect framework endpoints (#3548) * Only run publishing jobs when all dependent pipelines succeed (#3635) Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * chore(profiling): update libdatadog to 26 (#3633) * test(CI): manually handle git operation for windows jobs (#3634) * test(CI): add aggressive git cleanup on windows runner Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * test(CI): add manual cleanup in before_script step Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> --------- Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat(CI): add healthcheck to SQLSRV server setup (#3619) * feat(CI): add healthcheck to SQLSRV server setup Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: add troubleshooting script for SQLSRV Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat: add explicit memory limit and paths Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: replace sqlsrv docker image Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> --------- Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * fix(CI: test_metrics): add explicit flush in logging (#3637) * fix(logging): fsync crash logs before _Exit() to prevent data loss When a SIGSEGV occurs, the signal handler logs "Segmentation fault encountered" and then calls _Exit() which terminates the process immediately. Without fsync(), kernel write buffers may not be flushed to disk before termination, causing a race condition where the error log file is sometimes not created. This fix adds fsync() on Unix/Linux and _commit() on Windows after write() in ddtrace_log_with_time() to ensure crash logs persist to disk before process termination. The issue affects production (rare but possible during power loss, kernel panic, or I/O errors) and causes consistent test failures where tests check for log files immediately after crashes (before kernel writeback completes). Fixes flaky test_metrics SigSegVTest::testGet failures on Kubernetes where dd_php_error.log was not being created consistently. * fix(signals): move flush in sigsegv handler Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> --------- Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * Adds process_tags to live debugger payloads (#3580) * init process tags for APM Co-Authored-By: PROFeNoM <alexandre.choura@datadoghq.com> * feat(process_tags): add process_tags to tracing payloads * small auto review and fix test * bwoebi review * fix test * Adds process_tags to live debugger payloads * temporary libdatadog bump * auto review * bump libdatadog * fix build * update makefile && make cbindgen * fixing test * fixing test * fix appsec tests --------- Co-authored-by: PROFeNoM <alexandre.choura@datadoghq.com> * chore(profiling): update libdatadog 26 to 27 (#3640) * chore(profiling): update libdatadog 26 to 27 * process tags were removed while rebasing to sign commit --------- Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com> Co-authored-by: Alexandre Rulleau <55387832+Leiyks@users.noreply.github.com> Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com> Co-authored-by: Laplie Anderson <randomanderson@users.noreply.github.com> Co-authored-by: Alejandro Estringana Ruiz <alejandro.estringanaruiz@datadoghq.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: PROFeNoM <alexandre.choura@datadoghq.com>

refactor(profiling): extract Backtrace type

491a9e3

In a future change, this may hold a refcount for another object, so we need to encapsulate it.

github-actions bot added profiling Relates to the Continuous Profiler tracing labels Jan 31, 2026

This comment has been minimized.

Sign in to view

morrisonlevi removed the tracing label Jan 31, 2026

morrisonlevi marked this pull request as ready for review January 31, 2026 05:29

morrisonlevi requested a review from a team as a code owner January 31, 2026 05:29

fix test_collect_stack_sample not running

893a3b4

github-actions bot added the tracing label Feb 2, 2026

realFlowControl approved these changes Feb 2, 2026

View reviewed changes

morrisonlevi enabled auto-merge (squash) February 2, 2026 15:30

morrisonlevi disabled auto-merge February 2, 2026 15:31

Merge branch 'master' into levi/backtrace

9706a71

morrisonlevi merged commit 9de150f into master Feb 2, 2026
18 of 20 checks passed

morrisonlevi deleted the levi/backtrace branch February 2, 2026 15:32

github-actions bot added this to the 1.17.0 milestone Feb 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(profiling): extract Backtrace type#3612

refactor(profiling): extract Backtrace type#3612
morrisonlevi merged 3 commits intomasterfrom
levi/backtrace

morrisonlevi commented Jan 31, 2026

Uh oh!

This comment has been minimized.

codecov-commenter commented Jan 31, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

realFlowControl commented Feb 2, 2026

Uh oh!

realFlowControl left a comment

Uh oh!

realFlowControl Feb 2, 2026

Uh oh!

morrisonlevi commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

morrisonlevi commented Jan 31, 2026

Description

Reviewer checklist

Uh oh!

This comment has been minimized.

codecov-commenter commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ profiler ]

scenario:walk_stack/50

scenario:walk_stack/99

Uh oh!

realFlowControl commented Feb 2, 2026

Uh oh!

realFlowControl left a comment

Choose a reason for hiding this comment

Uh oh!

realFlowControl Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

morrisonlevi commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Jan 31, 2026 •

edited

Loading

pr-commenter bot commented Jan 31, 2026 •

edited

Loading