Skip to content

Commit 6b4cd2e

Browse files
ci(sanic): skip sanic framework test [backport 1.19] (#7374)
Backport 817003a from #7366 to 1.19. This PR is against the 1.20 branch, since it and below are the ones that are failing or timing out on the Sanic framework test. Sanic test is consistently timing out or failing on <=1.20. Skipping for now. I tried to add a time based skip, however I ran into some issues getting the time in an easily comparable format. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that. Co-authored-by: Zachary Groves <[email protected]>
1 parent 30d9053 commit 6b4cd2e

File tree

1 file changed

+34
-34
lines changed

1 file changed

+34
-34
lines changed

.github/workflows/test_frameworks.yml

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -74,40 +74,40 @@ jobs:
7474
# log output and it contains phony error messages.
7575
run: PYTHONPATH=../ddtrace/tests/debugging/exploration/ ddtrace-run pytest test --continue-on-collection-errors -v -k 'not test_simple'
7676

77-
sanic-testsuite-22_12:
78-
runs-on: ubuntu-20.04
79-
needs: needs-run
80-
env:
81-
# Regression test for DataDog/dd-trace-py/issues/5722
82-
DD_UNLOAD_MODULES_FROM_SITECUSTOMIZE: true
83-
CMAKE_BUILD_PARALLEL_LEVEL: 12
84-
defaults:
85-
run:
86-
working-directory: sanic
87-
steps:
88-
- uses: actions/checkout@v3
89-
if: needs.needs-run.outputs.outcome == 'success'
90-
with:
91-
path: ddtrace
92-
- uses: actions/checkout@v3
93-
if: needs.needs-run.outputs.outcome == 'success'
94-
with:
95-
repository: sanic-org/sanic
96-
ref: v22.12.0
97-
path: sanic
98-
- uses: actions/setup-python@v4
99-
if: needs.needs-run.outputs.outcome == 'success'
100-
with:
101-
python-version: "3.11"
102-
- name: Install sanic and dependencies required to run tests
103-
if: needs.needs-run.outputs.outcome == 'success'
104-
run: pip3 install '.[test]' aioquic
105-
- name: Install ddtrace
106-
if: needs.needs-run.outputs.outcome == 'success'
107-
run: pip3 install ../ddtrace
108-
- name: Run tests
109-
if: needs.needs-run.outputs.outcome == 'success'
110-
run: ddtrace-run pytest -k "not test_add_signal and not test_ode_removes and not test_skip_touchup and not test_dispatch_signal_triggers and not test_keep_alive_connection_context and not test_redirect_with_params"
77+
# sanic-testsuite-22_12:
78+
# runs-on: ubuntu-20.04
79+
# needs: needs-run
80+
# env:
81+
# # Regression test for DataDog/dd-trace-py/issues/5722
82+
# DD_UNLOAD_MODULES_FROM_SITECUSTOMIZE: true
83+
# CMAKE_BUILD_PARALLEL_LEVEL: 12
84+
# defaults:
85+
# run:
86+
# working-directory: sanic
87+
# steps:
88+
# - uses: actions/checkout@v3
89+
# if: needs.needs-run.outputs.outcome == 'success'
90+
# with:
91+
# path: ddtrace
92+
# - uses: actions/checkout@v3
93+
# if: needs.needs-run.outputs.outcome == 'success'
94+
# with:
95+
# repository: sanic-org/sanic
96+
# ref: v22.12.0
97+
# path: sanic
98+
# - uses: actions/setup-python@v4
99+
# if: needs.needs-run.outputs.outcome == 'success'
100+
# with:
101+
# python-version: "3.11"
102+
# - name: Install sanic and dependencies required to run tests
103+
# if: needs.needs-run.outputs.outcome == 'success'
104+
# run: pip3 install '.[test]' aioquic
105+
# - name: Install ddtrace
106+
# if: needs.needs-run.outputs.outcome == 'success'
107+
# run: pip3 install ../ddtrace
108+
# - name: Run tests
109+
# if: needs.needs-run.outputs.outcome == 'success'
110+
# run: ddtrace-run pytest -k "not test_add_signal and not test_ode_removes and not test_skip_touchup and not test_dispatch_signal_triggers and not test_keep_alive_connection_context and not test_redirect_with_params"
111111

112112
django-testsuite-3_1:
113113
strategy:

0 commit comments

Comments
 (0)