Skip to content

Commit 70e951c

Browse files
author
Emanuele Palazzetti
committed
[django] comments for improvements
1 parent 1cca7b9 commit 70e951c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

ddtrace/contrib/django/middleware.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
class TraceMiddleware(object):
2020
def __init__(self):
21+
# TODO[manu]: maybe we can formalize better DJANGO_SETTINGS_* stuff
22+
# providing defaults or raise ImproperlyConfigured errors
2123
tracer_import = getattr(settings, 'DATADOG_TRACER', 'ddtrace.tracer')
2224
self.tracer = import_from_string(tracer_import, 'DATADOG_TRACER')
2325
self.service = getattr(settings, 'DATADOG_SERVICE', 'django')
@@ -29,6 +31,9 @@ def __init__(self):
2931
)
3032

3133
try:
34+
# TODO[manu]: maybe it's better to provide a Django app that
35+
# will patch everything once instead of trying that for
36+
# each request (in the case of patch_db)?
3237
patch_template(self.tracer)
3338
except Exception:
3439
log.exception("error patching template class")

0 commit comments

Comments
 (0)