Skip to content

Commit 74f5fb7

Browse files
authored
Revert "[cassandra] Fix batched query leak (#714)" (#765)
This reverts commit cb245cd.
1 parent cb245cd commit 74f5fb7

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

ddtrace/contrib/cassandra/session.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,9 @@ def _sanitize_query(span, query):
253253
# reset query if a string is available
254254
resource = getattr(query, "query_string", query)
255255
elif t == 'BatchStatement':
256-
resource = '; '.join(q[1] for q in query._statements_and_parameters[:2])
256+
resource = 'BatchStatement'
257+
q = "; ".join(q[1] for q in query._statements_and_parameters[:2])
258+
span.set_tag("cassandra.query", q)
257259
span.set_metric("cassandra.batch_size", len(query._statements_and_parameters))
258260
elif t == 'BoundStatement':
259261
ps = getattr(query, 'prepared_statement', None)

tests/contrib/cassandra/test.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -264,15 +264,9 @@ def test_batch_statement(self):
264264
spans = writer.pop()
265265
eq_(len(spans), 1)
266266
s = spans[0]
267-
eq_(
268-
s.resource,
269-
(
270-
'INSERT INTO test.person_write (name, age, description) VALUES (\'Joe\', 1, \'a\'); '
271-
'INSERT INTO test.person_write (name, age, description) VALUES (\'Jane\', 2, \'b\')'
272-
)
273-
)
267+
eq_(s.resource, 'BatchStatement')
274268
eq_(s.get_metric('cassandra.batch_size'), 2)
275-
assert s.get_tag('cassandra.query') is None
269+
assert 'test.person' in s.get_tag('cassandra.query')
276270

277271

278272
class TestCassPatchDefault(CassandraBase):

0 commit comments

Comments
 (0)