Skip to content

Commit bf8dd49

Browse files
committed
Remove dead weight attribute
1 parent f377044 commit bf8dd49

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

ddtrace/sampler.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ def set_sample_rate(self, sample_rate):
4343

4444
def sample(self, span):
4545
span.sampled = span.trace_id <= self.sampling_id_threshold
46-
# `weight` is an attribute applied to all spans to help scaling related statistics
47-
span.weight = 1 / (self.sample_rate or 1)
4846

4947

5048
class ThroughputSampler(object):

ddtrace/span.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class Span(object):
3030
'duration',
3131
# Sampler attributes
3232
'sampled',
33-
'weight',
3433
# Internal attributes
3534
'_tracer',
3635
'_finished',
@@ -89,7 +88,6 @@ def __init__(
8988

9089
# sampling
9190
self.sampled = True
92-
self.weight = 1
9391

9492
self._tracer = tracer
9593
self._parent = None
@@ -185,7 +183,6 @@ def to_dict(self):
185183
'resource' : self.resource,
186184
'name' : self.name,
187185
'error': self.error,
188-
'weight': self.weight,
189186
}
190187

191188
if self.start:

tests/test_sampler.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ def test_random_sequence(self):
2626
# First trace, sampled
2727
with tracer.trace("foo") as s:
2828
assert s.sampled
29-
assert s.weight == 2
3029
assert writer.pop()
3130

3231
# Second trace, not sampled

0 commit comments

Comments
 (0)