Skip to content

Commit ef5e4ec

Browse files
ci: switch reliability env deployments to be scheduled (#5657)
This PR changes reliability env deploys to only happen when scheduled or manually triggered. Deploying on commits to the main branch noisy to see medium-term trends. Switching to a scheduled deploy should help. Testing will be ensuring the scheduled job correctly deploys to the rel-env. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] PR description includes explicit acknowledgement/acceptance of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
1 parent c573fb9 commit ef5e4ec

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.gitlab-ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ variables:
99
DOWNSTREAM_BRANCH:
1010
value: "master"
1111
description: "Run a specific datadog-reliability-env branch downstream"
12-
FORCE_TRIGGER:
13-
value: "false"
14-
description: "Set to true to override rules in the reliability-env pipeline (e.g. override 'only deploy master')"
1512
DOWNSTREAM_MBP_BRANCH:
1613
value: "dd-trace-py"
1714
description: "Run a specific relenv-microbenchmarking-platform branch downstream"
@@ -22,7 +19,11 @@ variables:
2219

2320
deploy_to_reliability_env:
2421
stage: deploy
25-
when: on_success
22+
rules:
23+
- if: $CI_PIPELINE_SOURCE == "scheduled"
24+
when: on_success
25+
- when: manual
26+
allow_failure: true
2627
trigger:
2728
project: DataDog/apm-reliability/datadog-reliability-env
2829
branch: $DOWNSTREAM_BRANCH
@@ -31,7 +32,6 @@ deploy_to_reliability_env:
3132
UPSTREAM_PROJECT_NAME: $CI_PROJECT_NAME
3233
UPSTREAM_BRANCH: $CI_COMMIT_REF_NAME
3334
UPSTREAM_COMMIT_SHA: $CI_COMMIT_SHA
34-
FORCE_TRIGGER: $FORCE_TRIGGER
3535

3636
deploy_to_di_backend:automatic:
3737
stage: deploy

0 commit comments

Comments
 (0)