-
Notifications
You must be signed in to change notification settings - Fork 463
fix(kafka): only the first message was dispatch to dsm #14946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 1 ms. The average import time from base is: 240 ± 2 ms. The import time difference between this PR and base is: -2.16 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate dubloom/fix-kafka-consume (5feb2df) with baseline main (0b0f0d3) ❌ Test Failures (1 suite)❌ otelspan - 20/22✅ add-eventTime: ✅ 40.463ms (SLO: <47.150ms 📉 -14.2%) vs baseline: +0.5% Memory: ✅ 43.772MB (SLO: <47.000MB -6.9%) vs baseline: +4.9% ❌ add-metricsTime: ✅ 320.023ms (SLO: <344.800ms -7.2%) vs baseline: +1.4% Memory: ❌ 652.870MB (SLO: <630.000MB +3.6%) vs baseline: +4.8% ❌ add-tagsTime: ✅ 287.063ms (SLO: <314.000ms -8.6%) vs baseline: -0.3% Memory: ❌ 653.947MB (SLO: <630.000MB +3.8%) vs baseline: +4.9% ✅ get-contextTime: ✅ 81.790ms (SLO: <92.350ms 📉 -11.4%) vs baseline: +2.2% Memory: ✅ 39.656MB (SLO: <46.500MB 📉 -14.7%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 38.867ms (SLO: <44.500ms 📉 -12.7%) vs baseline: +2.0% Memory: ✅ 43.140MB (SLO: <47.500MB -9.2%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 58.332ms (SLO: <67.650ms 📉 -13.8%) vs baseline: +0.6% Memory: ✅ 39.866MB (SLO: <47.000MB 📉 -15.2%) vs baseline: +4.8% ✅ set-statusTime: ✅ 44.780ms (SLO: <50.400ms 📉 -11.2%) vs baseline: +2.3% Memory: ✅ 43.191MB (SLO: <47.000MB -8.1%) vs baseline: +4.8% ✅ startTime: ✅ 37.810ms (SLO: <43.450ms 📉 -13.0%) vs baseline: +1.3% Memory: ✅ 43.187MB (SLO: <47.000MB -8.1%) vs baseline: +4.7% ✅ start-finishTime: ✅ 81.892ms (SLO: <88.000ms -6.9%) vs baseline: ~same Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 84.922ms (SLO: <89.000ms -4.6%) vs baseline: +1.5% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.7% ✅ update-nameTime: ✅ 39.811ms (SLO: <45.150ms 📉 -11.8%) vs baseline: +2.3% Memory: ✅ 43.499MB (SLO: <47.000MB -7.4%) vs baseline: +4.8% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.467ms (SLO: <22.300ms -8.2%) vs baseline: ~same Memory: ✅ 65.547MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.347ms (SLO: <1.450ms -7.1%) vs baseline: ~same Memory: ✅ 64.512MB (SLO: <67.000MB -3.7%) vs baseline: +4.7% ✅ iastTime: ✅ 20.450ms (SLO: <22.250ms -8.1%) vs baseline: -0.3% Memory: ✅ 65.449MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.262ms (SLO: <16.550ms -7.8%) vs baseline: ~same Memory: ✅ 53.823MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.475ms (SLO: <21.750ms -5.9%) vs baseline: -0.3% Memory: ✅ 65.476MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.383ms (SLO: <28.200ms -10.0%) vs baseline: -0.2% Memory: ✅ 67.544MB (SLO: <69.500MB -2.8%) vs baseline: +4.8% ✅ tracerTime: ✅ 20.397ms (SLO: <21.750ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.441MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.032ms (SLO: <23.500ms -6.2%) vs baseline: ~same Memory: ✅ 66.658MB (SLO: <67.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.292ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.3% Memory: ✅ 65.493MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.644ms (SLO: <17.500ms -4.9%) vs baseline: ~same Memory: ✅ 65.442MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.418ms (SLO: <21.750ms -6.1%) vs baseline: -0.3% Memory: ✅ 71.261MB (SLO: <72.500MB 🟡 -1.7%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.465ms (SLO: <19.650ms -6.0%) vs baseline: +0.2% Memory: ✅ 65.450MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.749ms (SLO: <20.100ms -6.7%) vs baseline: -0.2% Memory: ✅ 65.412MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.246ms (SLO: <21.500ms -5.8%) vs baseline: +0.4% Memory: ✅ 65.464MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.328ms (SLO: <22.000ms -7.6%) vs baseline: +0.2% Memory: ✅ 65.516MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 17.991ms (SLO: <19.850ms -9.4%) vs baseline: ~same Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.007ms (SLO: <19.400ms -7.2%) vs baseline: -0.3% Memory: ✅ 65.195MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.153ms (SLO: <19.450ms -6.7%) vs baseline: +0.6% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: +0.2% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.623ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.584ms (SLO: <4.750ms -3.5%) vs baseline: -0.2% Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: +0.2% Memory: ✅ 45.456MB (SLO: <47.000MB -3.3%) vs baseline: +5.1% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: +0.1% Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: -0.2% Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: -0.5% Memory: ✅ 52.298MB (SLO: <53.500MB -2.2%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: +0.3% Memory: ✅ 58.188MB (SLO: <60.000MB -3.0%) vs baseline: +4.6%
|
The kafka integration was dispatching only the first message when consuming several messages at the same time.
While only the first message is used to set the span metadata, all messages should be dispatched as it is used by DSM