[PROF-11412] Support correlating profiling with otel-api 1.5+ #4425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to access the OTEL context after open-telemetry/opentelemetry-ruby#1807 .
**What does this PR do?** This PR adds support for correlating profiling wih otel-api 1.5+. Context storage was moved in open-telemetry/opentelemetry-ruby#1807 and we needed to update the profiler to account for this. **Motivation:** Keep profiling + otel correlation working. **Additional Notes:** N/A **How to test the change?** In #4421 I had already bootstrapped the new appraisal groups needed for testing this. This PR enables them, and our existing test coverage will cover the new code path when used with otel-api 1.5+.
ivoanjo
added
profiling
BenchmarksBenchmark execution time: 2025-02-21 11:48:08 Comparing candidate commit 16b8c46 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4425 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 1365 1365
Lines 83337 83337
Branches 4219 4219
=======================================
+ Hits 81440 81443 +3
+ Misses 1897 1894 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20607 Passed, 1375 Skipped, 3m 9.05s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for correlating profiling wih otel-api 1.5+.
Context storage was moved in open-telemetry/opentelemetry-ruby#1807 and we needed to update the profiler to account for this.
Motivation:
Keep profiling + otel correlation working.
Change log entry
Yes. Support correlating profiling with otel-api 1.5+
Additional Notes:
N/A
How to test the change?
In #4421 I had already bootstrapped the new appraisal groups needed for testing this. This PR enables them, and our existing test coverage will cover the new code path when used with otel-api 1.5+.