Conversation
Typing analysisNote: Ignored files are excluded from the next sections.
|
BenchmarksBenchmark execution time: 2026-02-10 11:40:17 Comparing candidate commit ff906db in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:profiling - Allocations ()
scenario:tracing - Propagation - Datadog
|
7f6cab6 to
bf94d2d
Compare
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: ff906db | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Strech
commented
Feb 5, 2026
spec/datadog/appsec/contrib/excon/ssrf_detection_middleware_spec.rb
Outdated
Show resolved
Hide resolved
* Update Faraday contrib with body analysis conditions * Update Faraday vendor RBS stab
b3d873b to
ff906db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
This is a second batch of changes for http libraries instrumentations that brings a request/response body analysis based on sampling/limit settings.
Change log entry
Yes. AppSec: Add downstream request body analysis.
Additional Notes:
This is 2/3 of the original RFC and the announcement will come with a third one. You can spot that all contribs changes look-a-like and it's known issue due to the lack of events system we slowly moving to (i.e will be refactored one day)
How to test the change?
CI + ST