Skip to content

Fix flaky benchmark validation tests by skipping fork in validation mode #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bm1549 merged 2 commits into from
Feb 12, 2026
Merged

Fix flaky benchmark validation tests by skipping fork in validation mode #5353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15d53d8
Fix flaky benchmark validation tests by skipping fork in validation mode
bm1549 Feb 12, 2026
d0c2d33
Merge branch 'master' into brian.marks/fix-flakes
ivoanjo Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions benchmarks/error_tracking_simple.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,15 @@ def benchmark_simple_third_party(with_error: false)
puts "Current pid is #{Process.pid}"

def run_benchmark(&block)
# Forking to avoid monkey-patching leaking between benchmarks
pid = fork(&block)
_, status = Process.wait2(pid)

raise "Benchmark failed with status #{status}" unless status.success?
if VALIDATE_BENCHMARK_MODE
block.call
else
# Forking to avoid monkey-patching leaking between benchmarks
pid = fork(&block)
_, status = Process.wait2(pid)

raise "Benchmark failed with status #{status}" unless status.success?
end
end

ErrorTrackingSimpleBenchmark.new.instance_exec do
Expand Down
14 changes: 9 additions & 5 deletions benchmarks/tracing_trace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,15 @@ def benchmark_propagation_trace_context
puts "Current pid is #{Process.pid}"

def run_benchmark(&block)
# Forking to avoid monkey-patching leaking between benchmarks
pid = fork { block.call }
_, status = Process.wait2(pid)

raise "Benchmark failed with status #{status}" unless status.success?
if VALIDATE_BENCHMARK_MODE
block.call
else
# Forking to avoid monkey-patching leaking between benchmarks
pid = fork { block.call }
_, status = Process.wait2(pid)

raise "Benchmark failed with status #{status}" unless status.success?
end
end

TracingTraceBenchmark.new.instance_exec do
Expand Down
Loading