Skip to content

[APPSEC-60626] Remove Faraday from Steep ignore list#5355

Merged
Strech merged 2 commits intomasterfrom
appsec-60626-add-faraday-contrib-to-steep
Feb 13, 2026
Merged

[APPSEC-60626] Remove Faraday from Steep ignore list#5355
Strech merged 2 commits intomasterfrom
appsec-60626-add-faraday-contrib-to-steep

Conversation

@Strech
Copy link
Member

@Strech Strech commented Feb 12, 2026

What does this PR do?

Removes Faraday contrib from the ignore list and add additional vendor gem typing.

Motivation:

Better type checking for development.

Change log entry

No.

Additional Notes:

AI was used with provided source code of the gem and result was reviewed.

How to test the change?

CI

@Strech Strech requested review from a team as code owners February 12, 2026 16:29
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Feb 12, 2026
@Strech Strech force-pushed the appsec-60626-add-faraday-contrib-to-steep branch from c750f48 to 5306211 Compare February 12, 2026 16:34
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Typing analysis

Ignored files

This PR clears 5 ignored files. It increases the percentage of typed files from 42.43% to 42.98% (+0.55%).

Ignored files (+0-5)Cleared:
lib/datadog/appsec/contrib/faraday/connection_patch.rb
lib/datadog/appsec/contrib/faraday/integration.rb
lib/datadog/appsec/contrib/faraday/patcher.rb
lib/datadog/appsec/contrib/faraday/rack_builder_patch.rb
lib/datadog/appsec/contrib/faraday/ssrf_detection_middleware.rb

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 2 partially typed methods. It increases the percentage of typed methods from 60.13% to 60.38% (+0.25%).

Partially typed methods (+2-0)Introduced:
sig/datadog/appsec/contrib/faraday/connection_patch.rbs:6
└── def initialize: (*untyped) ?{ (::Faraday::Connection) -> void } -> void
sig/datadog/appsec/contrib/faraday/rack_builder_patch.rbs:6
└── def adapter: (*untyped) -> ::Faraday::RackBuilder::Handler?

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept on the line before the definition to remove it from the stats.

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2026

Benchmarks

Benchmark execution time: 2026-02-13 12:19:15

Comparing candidate commit 1bb5dff in PR branch appsec-60626-add-faraday-contrib-to-steep with baseline commit 4f22dac in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@datadog-official
Copy link

datadog-official bot commented Feb 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 95.11% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1bb5dff | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@Strech Strech merged commit 6d1d8ad into master Feb 13, 2026
619 checks passed
@Strech Strech deleted the appsec-60626-add-faraday-contrib-to-steep branch February 13, 2026 13:48
@github-actions github-actions bot added this to the 2.29.0 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product integrations Involves tracing integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants