Skip to content

feat(benches): extraction benchmark #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(benches): extraction benchmark #90

wants to merge 3 commits into from
+235 −0

Conversation

iunanua
Copy link
Collaborator

@iunanua iunanua commented Sep 23, 2025

What does this PR do?

Add extract_benchmark for datadog and tracecontext headers

Additional Notes

After some attempts, it seems there is no obvious improvements in the extraction part, at least as in the injection part

@iunanua iunanua marked this pull request as ready for review October 10, 2025 10:09
@iunanua iunanua requested a review from a team as a code owner October 10, 2025 10:09
bantonsson
bantonsson approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase the branch as well. There have been optimizations done for the extraction that are now in main.

bantonsson
bantonsson reviewed Oct 10, 2025
View reviewed changes
@iunanua
Copy link
Collaborator Author

iunanua commented Oct 10, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-10 13:11:54 UTC ℹ️ Start processing command /merge

2025-10-10 13:12:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-10 13:29:48 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@iunanua
Copy link
Collaborator Author

iunanua commented Oct 10, 2025

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-10 13:29:43 UTC ℹ️ Start processing command /remove

2025-10-10 13:29:46 UTC ℹ️ Devflow: /remove

@iunanua
Copy link
Collaborator Author

iunanua commented Oct 10, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-10 13:30:26 UTC ℹ️ Start processing command /merge

2025-10-10 13:30:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-10 14:25:21 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@iunanua
Copy link
Collaborator Author

iunanua commented Oct 10, 2025

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-10 14:25:15 UTC ℹ️ Start processing command /remove

2025-10-10 14:25:19 UTC ℹ️ Devflow: /remove

@iunanua
Copy link
Collaborator Author

iunanua commented Oct 10, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-10 14:25:58 UTC ℹ️ Start processing command /merge

2025-10-10 14:26:05 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-10 18:27:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bantonsson bantonsson bantonsson approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iunanua @bantonsson