Document new dd_hostname field for fluentbit integration
#23966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in fluent/fluent-bit#8988 Easiest to review with whitespace changes ignored Signed-off-by: Jesse Szwedko <[email protected]>
Contributor
Preview links (active after the
|
hestonhoffman
approved these changes
Jul 2, 2024
Contributor
hestonhoffman
left a comment
hestonhoffman
left a comment
There was a problem hiding this comment.
Small edit. I'll commit and merge
Contributor
|
@jszwedko I noticed you didn't check the box in the PR description. Am I good to merge this one? |
Contributor
Author
|
Thanks @hestonhoffman . Note I think we may want to hold off on merging this until the next fluentbit release since the option is currently unreleased. I'll drop a comment when this is ready to be merged. |
Contributor
|
@jszwedko Ah good call. Thanks! Let us know when it's ready to go and we'll merge it in |
Contributor
Author
|
@hestonhoffman this is good to merge now since the change has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Documents the new
dd_hostnamefield added to the fluentbit integration: fluent/fluent-bit#8988Merge instructions
Waiting for fluentbit release.
Additional notes