-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Rtrieu/docs 11848 decouple expo et docs #32020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@rtrieu Just checking - no new content here? |
hey @hestonhoffman there is definitely some net new content here. I moved some setup info from RUM to ET and modified it. I also added more details to existing pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rtrieu looks good I just have one question about the link to the command documentation, thanks!
content/en/real_user_monitoring/application_monitoring/react_native/setup/expo.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/react_native/setup/expo.md
Show resolved
Hide resolved
Co-authored-by: Alicia Thuerk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes