-
Notifications
You must be signed in to change notification settings - Fork 1.2k
llmobs: Otel Ingestion GA #32977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
llmobs: Otel Ingestion GA #32977
Conversation
Preview links (active after the
|
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tweaks! We try to avoid temporal terms like "currently" so I cut that out.
content/en/llm_observability/evaluations/external_evaluations.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
barieom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, left minor suggestions
content/en/llm_observability/evaluations/external_evaluations.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
Co-authored-by: domalessi <[email protected]>
…ion.md Co-authored-by: domalessi <[email protected]>
…ion.md Co-authored-by: domalessi <[email protected]>
…ion.md Co-authored-by: Barry Eom <[email protected]>
…ion.md Co-authored-by: Barry Eom <[email protected]>
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more tiny things!
content/en/llm_observability/evaluations/external_evaluations.md
Outdated
Show resolved
Hide resolved
content/en/llm_observability/instrumentation/otel_instrumentation.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question but otherwise LGTM
…ion.md Co-authored-by: domalessi <[email protected]>
Co-authored-by: domalessi <[email protected]>
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
What does this PR do? What is the motivation?
Makes the page public, updates to say 1.37+ for otel spec requirements now that 1.38 has come out, adds a note that we don't support custom evaluations for otel spans (although we do plan on adding this in the next couple of weeks).
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes