-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add documentation for GraphQL iOS #33482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
|
Thank you! I have created DOCS card for someone on our team to review further. |
content/en/real_user_monitoring/application_monitoring/ios/advanced_configuration.md
Outdated
Show resolved
Hide resolved
f60d387 to
b2d46aa
Compare
rtrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments regarding formatting, mostly
| #### Apollo instrumentation | ||
| This integration supports both Apollo iOS 1.0+ and Apollo iOS 2.0+. The setup differs between versions, so please follow the instructions for your Apollo iOS version below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This integration supports both Apollo iOS 1.0+ and Apollo iOS 2.0+. The setup differs between versions, so please follow the instructions for your Apollo iOS version below. | |
| This integration supports both Apollo iOS 1.0+ and Apollo iOS 2.0+. Follow the instructions for the Apollo iOS version you have below. |
| 2. Add the following to your application's `Package.swift` file: | ||
| ```swift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please indent lines 764-777 by 3 spaces
| ``` | ||
|
|
||
| Alternatively, you can add it using Xcode: | ||
| - Go to **File** → **Add Package Dependencies** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Go to **File** → **Add Package Dependencies** | |
| 1. Go to **File** → **Add Package Dependencies**. |
|
|
||
| Alternatively, you can add it using Xcode: | ||
| - Go to **File** → **Add Package Dependencies** | ||
| - Enter the repository URL: `https://github.com/DataDog/dd-sdk-ios-apollo-interceptor` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Enter the repository URL: `https://github.com/DataDog/dd-sdk-ios-apollo-interceptor` | |
| 2. Enter the repository URL: `https://github.com/DataDog/dd-sdk-ios-apollo-interceptor`. |
| Alternatively, you can add it using Xcode: | ||
| - Go to **File** → **Add Package Dependencies** | ||
| - Enter the repository URL: `https://github.com/DataDog/dd-sdk-ios-apollo-interceptor` | ||
| - Select the package version that matches your Apollo major version (choose `1.x.x` for Apollo iOS 1.0+ or `2.x.x` for Apollo iOS 2.0+). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Select the package version that matches your Apollo major version (choose `1.x.x` for Apollo iOS 1.0+ or `2.x.x` for Apollo iOS 2.0+). | |
| 3. Select the package version that matches your Apollo major version (choose `1.x.x` for Apollo iOS 1.0+ or `2.x.x` for Apollo iOS 2.0+). |
| {{% /tab %}} | ||
| {{< /tabs >}} | ||
|
|
||
| This automatically adds Datadog headers to your GraphQL requests, enabling them to be tracked by Datadog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This automatically adds Datadog headers to your GraphQL requests, enabling them to be tracked by Datadog. | |
| This automatically adds Datadog headers to your GraphQL requests, enabling them to be tracked by Datadog. |
content/en/real_user_monitoring/application_monitoring/ios/advanced_configuration.md
Show resolved
Hide resolved
…anced_configuration.md Co-authored-by: Rosa Trieu <[email protected]>
f1b7d68 to
7618e2a
Compare
gonzalezreal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM!
* Add documentation for GraphQL iOS * Fix: link * Fix: update v2 configuration * Fix: use info alert * Apply PR suggestions * Fix indentation * Update content/en/real_user_monitoring/application_monitoring/ios/advanced_configuration.md Co-authored-by: Rosa Trieu <[email protected]> * Fix: datadog doesnt add headers --------- Co-authored-by: Rosa Trieu <[email protected]>
What does this PR do? What is the motivation?
Now that Datadog Apollo Interceptor for iOS has been released, I am adding documentation about how to use it.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes