-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Mapping Canonical Cloud Resources ID to OpenTelemetry resource attributes #33487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Preview links (active after the
|
songy23
reviewed
Jan 2, 2026
songy23
approved these changes
Jan 2, 2026
Contributor
hestonhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left you some style edits and a question
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
hestonhoffman
approved these changes
Jan 2, 2026
dd-mergequeue bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Jan 5, 2026
### What does this PR do? Add CCRID to the host metadata resource attribute conventions https://datadoghq.atlassian.net/browse/OTAGENT-583 ### Motivation Improve traceability in virtual env. of different cloud providers. Linked documentation PR: DataDog/documentation#33487 ### Describe how you validated your changes Manual tests and checks that for each pipeline the attribute `datadog.ccrid` is properly handled and inserted into metadata. * `./telemetrygen logs --otlp-insecure --otlp-attributes "datadog.ccrid"=\"CCRID_LOGS\" --otlp-attributes "datadog.host.name"=\"azh4523\" --duration 5s` * `./telemetrygen metrics --otlp-insecure --otlp-attributes "datadog.ccrid"=\"CCRID_METRICS\" --otlp-attributes "datadog.host.name"=\"azh4523\" --duration 5s` * `./telemetrygen traces --otlp-insecure --otlp-attributes "datadog.ccrid"=\"CCRID_TRACES\" --otlp-attributes "datadog.host.name"=\"azh4523\" --duration 5s` Staging: https://app.datadoghq.com/logs?query=service%3Asobotka%20azh4523&agg_m=count&agg_m_source=base&agg_t=count&cols=core_host%2Ccore_service&event=AwAAAZtvhvYDrOj1YAAAABhBWnR2aHZma0FBQjBWMnhjdEVFc3ZnQXkAAAAkZjE5YjZmOGEtZTk0NC00YmY4LThlY2EtNDQ5NDFhMDMyMzJlAAvfHw&messageDisplay=inline&refresh_mode=sliding&storage=hot&stream_sort=desc&viz=stream&from_ts=1766764081143&to_ts=1767368881143&live=true Co-authored-by: andrey.zheltovskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Documenting Canonical Cloud Resource IDs (CCRIDs) usage for DDOT
Merge instructions
The merge shall remain blocked until CCRID Metapayload support is implemented in DDOT
Merge readiness:
TO BE REMOVED:
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.