containers reorg (again) #34075
containers reorg (again) #34075
Conversation
|
Hi @ceciliawatt when you have a moment can you fix the merge conflict so it will build the staging links? Thank you! |
git-thuerk-done
left a comment
git-thuerk-done
left a comment
There was a problem hiding this comment.
Hi @cswatt this looks great, I have just a few minor suggestions and then a suggestion for layout of the main containers/ page but perhaps for another iteration :)
There was a problem hiding this comment.
A general comment on this page as it's quite long, maybe for the next iteration you could consider using the multi-code-lang feature
Here is a PR where I used it on a page that contains non-traditional "code-lang" definitions, and the live page, so you can see how it looks, totally just an idea though!
The idea then would be to have buttons on the top (Docker, Kubernetes, Amazon, etc)
There was a problem hiding this comment.
Considering this is essentially a directory page, used mostly as a site map / by crawlers, and pretty easy to scan, I don't think the length is much of an issue. I think the multi-code-lang solution may actually make this page more difficult to parse by external crawlers.
There was a problem hiding this comment.
I noticed these are hidden (not on left hand nav, assume this is intentional) ?
There was a problem hiding this comment.
yup, intentional — they're FAQs
github-actions
bot
added
Architecture
Co-authored-by: Alicia Thuerk <[email protected]>
What does this PR do? What is the motivation?
Moved some files from the infrastructure section into the containers section, rearranging some information
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes