add(datadog-csi-driver): tolerations support

[man0s]

What this PR does / why we need it:

The CSI driver's Daemonset should be able to be provisioned in tainted nodes - otherwise we will get errors like the following if we try to access it through a workload in a tainted node:

MountVolume.SetUp failed for volume "datadog" : kubernetes.io/csi: mounter.SetUpAt failed to get CSI client: driver name k8s.csi.datadoghq.com not found in the list of registered CSI drivers

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
• For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

• Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
• CHANGELOG.md has been updated
• Variables are documented in the README.md

[adel121]

Thanks for the contribution.

Looks good.

Some things to keep in mind:

• We need to bump the csi chart version in datadog chart dependencies.
• Tolerations will be applied if driver is installed using the datadog-csi-driver directly. If it is installed indirectly via datadog-agent chart, tolerations should be set in values.yaml as follows to pass it down to the child chart:

datadog-csi-driver:
  tolerations:
    - key: "k"
      operator: "Exists"
      effect: "NoSchedule"

[man0s]

Thanks for the contribution.

Looks good.

Some things to keep in mind:

* We need to bump the csi chart version in datadog chart dependencies.

* Tolerations will be applied if driver is installed using the datadog-csi-driver directly. If it is installed indirectly via datadog-agent chart, tolerations should be set in `values.yaml` as follows to pass it down to the child chart:

datadog-csi-driver:
  tolerations:
    - key: "k"
      operator: "Exists"
      effect: "NoSchedule"

@adel121 I have just updated the dependencies as well as the values.yaml with a proper example.

[adel121]

@man0s

Thanks for taking care of this of updating the datadog-agent, and apologies for any confusion caused in my previous comment. By Some things to keep in mind: I meant Some things to keep in mind for the future:

But unfortunately this will fail the CI because version 0.4.4 of csi chart will only be published on helm after the PR has been fully merged.

I suggest not updating datadog-agent chart in this PR. Let's focus on CSI for now and we can bump the csi dependency version and add the examples (Which look great 🙇 ).

Feel free to open a separate PR for datadog-agent chart if you prefer, and I can approve it once CSI chart is published after merging this current PR.

[adel121]

Left a comment, thanks!

[man0s]

@man0s

Thanks for taking care of this of updating the datadog-agent, and apologies for any confusion caused in my previous comment. By Some things to keep in mind: I meant Some things to keep in mind for the future:

But unfortunately this will fail the CI because version 0.4.4 of csi chart will only be published on helm after the PR has been fully merged.

I suggest not updating datadog-agent chart in this PR. Let's focus on CSI for now and we can bump the csi dependency version and add the examples (Which look great 🙇 ).

Feel free to open a separate PR for datadog-agent chart if you prefer, and I can approve it once CSI chart is published after merging this current PR.

Thanks for the review, got it - as the test will fail since the helm chart will not be there! 🥇
I have just created to #2160 to handle the version bump.

[adel121]

Hello

The CI was having issues for the external contribution branches.

We cherry-picked your commits and created a branch internally.

#2170

It is already merged.

Closing this one.

Thank you for contributing