Skip to content

[CONTINT-4924] Support for wildcards in kind field in KSM RBAC #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 6 commits into from
Jan 8, 2026
Merged

[CONTINT-4924] Support for wildcards in kind field in KSM RBAC #2192

dd-mergequeue merged 6 commits into from
Jan 8, 2026
+11 −3

Conversation

@triviajon
Copy link
Contributor

@triviajon triviajon commented Nov 21, 2025 •
edited by atlassian bot
Loading

What this PR does / why we need it:

This is a followup PR to [datadog/datadog-agent: CONTINT-4903 Refactor KSM custom resource handling for wildcards](DataDog/datadog-agent#43315). This PR allows us to use a wildcard "*" in the Kind field of a GVK under Values.datadog.kubeStateMetricsCore.collectCrMetrics.

Which issue this PR fixes

Previously, we treated a wildcard here as an ordinary value, causing the template to fail to compile:

Error: INSTALLATION FAILED: YAML parse error on datadog/templates/kube-state-metrics-core-rbac.yaml: error converting YAML to JSON: yaml: unknown anchor 's' referenced```

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated

@triviajon triviajon requested a review from a team as a code owner November 21, 2025 18:34
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Nov 21, 2025
@triviajon triviajon mentioned this pull request Nov 24, 2025
Merged
2 tasks
tbavelier
tbavelier approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@tbavelier tbavelier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment on operator side, this should wait until we release 7.74 Agent I think. And changelog conflict will need to be resolved

@triviajon
Copy link
Contributor Author

triviajon commented Dec 31, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 31, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-31 16:48:30 UTC ℹ️ Start processing command /merge

2025-12-31 16:48:36 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-31 16:49:19 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@triviajon
Copy link
Contributor Author

triviajon commented Dec 31, 2025

/merge -c

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 31, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-31 16:49:14 UTC ℹ️ Start processing command /merge -c

@triviajon
Copy link
Contributor Author

triviajon commented Jan 8, 2026

Merging now that 7.74 was released

@triviajon
Copy link
Contributor Author

triviajon commented Jan 8, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 8, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-08 16:36:48 UTC ℹ️ Start processing command /merge

2026-01-08 16:37:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-08 17:24:31 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-08 17:24:46 UTC ❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

@triviajon
Copy link
Contributor Author

triviajon commented Jan 8, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 8, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-08 20:29:07 UTC ℹ️ Start processing command /merge

2026-01-08 20:29:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-08 21:15:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 50m (p90).

2026-01-08 21:59:06 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bb0a855 into main Jan 8, 2026
38 checks passed
@dd-mergequeue dd-mergequeue bot deleted the triviajon/CONTINT-4924/rbac-generation-wildcard-kind branch January 8, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

@bitomaxsp bitomaxsp bitomaxsp approved these changes

@tbavelier tbavelier tbavelier approved these changes

@frank-spano frank-spano frank-spano approved these changes

Assignees

No one assigned

Labels

chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@triviajon @clamoriniere @bitomaxsp @tbavelier @frank-spano