Skip to content

[CXP-2598] deprecate datadog.processAgent.runInCoreAgent #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 7 commits into from
Jan 5, 2026
Merged

[CXP-2598] deprecate datadog.processAgent.runInCoreAgent #2265

dd-mergequeue merged 7 commits into from
Jan 5, 2026
+53 −49

Conversation

@daniel-taf
Copy link
Contributor

@daniel-taf daniel-taf commented Dec 23, 2025 •
edited
Loading

What this PR does / why we need it:

deprecates datadog.processAgent.runInCoreAgent. This behavior is now baselined in the chart logic.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@daniel-taf daniel-taf added the datadog/minor-version Minor version bump for datadog chart label Dec 23, 2025
@daniel-taf daniel-taf force-pushed the daniel.tafoya/deprecate-run-in-core-agent branch from 947df44 to 4cc664c Compare December 23, 2025 20:34
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Dec 23, 2025
@dd-octo-sts
chore: update charts
57fdfc4 
- bump version for datadog to 3.158.0 (minor-version)
- update changelog for datadog with version 3.158.0
- update readme for datadog
@daniel-taf daniel-taf changed the title deprecate-run-in-core-agent deprecate datadog.processAgent.runInCoreAgent Dec 23, 2025
daniel-taf
daniel-taf commented Dec 23, 2025
View reviewed changes
charts/datadog/values.yaml
Comment on lines +846 to 847
## DEPRECATED: This behavior will be enabled by default for installations that meet the requirements.
runInCoreAgent: true
Copy link
Contributor Author

@daniel-taf daniel-taf Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its possible to remove this from the values.yaml entirely and check presence of it in the deprecation notice using hasKey. Is this preferred?

@daniel-taf daniel-taf changed the title deprecate datadog.processAgent.runInCoreAgent [CXP-2598] deprecate datadog.processAgent.runInCoreAgent Dec 23, 2025
@daniel-taf daniel-taf marked this pull request as ready for review December 23, 2025 23:37
@daniel-taf daniel-taf requested a review from a team as a code owner December 23, 2025 23:37
daniel-taf and others added 2 commits January 5, 2026 14:57
@daniel-taf
Merge branch 'main' into daniel.tafoya/deprecate-run-in-core-agent
c7bacb9
@dd-octo-sts
chore: update charts
b57920d 
- bump version for datadog to 3.158.0 (minor-version)
- update changelog version for datadog to 3.158.0
- update readme for datadog
@daniel-taf
Copy link
Contributor Author

daniel-taf commented Jan 5, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 5, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-05 21:10:07 UTC ℹ️ Start processing command /merge

2026-01-05 21:10:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 51m (p90).

2026-01-05 21:10:52 UTC ℹ️ MergeQueue: Retrying because an high priority merge request needed to be processed first. No action is needed from your side.

2026-01-05 21:10:55 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@daniel-taf
Copy link
Contributor Author

daniel-taf commented Jan 5, 2026

/merge c

@daniel-taf
Copy link
Contributor Author

daniel-taf commented Jan 5, 2026

/remove

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 5, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-05 21:10:46 UTC ℹ️ Start processing command /remove

2026-01-05 21:10:50 UTC ℹ️ Devflow: /remove

@daniel-taf
Copy link
Contributor Author

daniel-taf commented Jan 5, 2026

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 5, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-05 21:11:47 UTC ℹ️ Start processing command /merge

2026-01-05 21:11:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 51m (p90).

2026-01-05 21:55:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit be26138 into main Jan 5, 2026
44 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daniel.tafoya/deprecate-run-in-core-agent branch January 5, 2026 21:55
@daniel-taf daniel-taf mentioned this pull request Jan 29, 2026
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swang392 swang392 swang392 approved these changes

Assignees

No one assigned

Labels

chart/datadog This issue or pull request is related to the datadog chart datadog/minor-version Minor version bump for datadog chart mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-taf @swang392