Skip to content

Conversation

@srinibddog
Copy link

What does this PR do?

Provides additional information about Custom Queries. Adds the key configuration information number of columns from the query should equal the number of custom query metrics in the conf.yaml file

Motivation

This information is not present in the documentation, rather in the example conf.yaml file.
This makes it easy to read from the documentation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [x ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-datadog-prod-us1

This comment has been minimized.


### Custom query

Custom Query is used to get specific fields from the database to be used a custom metrics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Custom Query is used to get specific fields from the database to be used a custom metrics.
Custom Query is used to extract specific fields from the database to be used as custom metrics.

| `columns` | This is a list representing each column, ordered sequentially from left to right. There are two required pieces of data: <br> a. `type` - This is the submission method (`gauge`, `count`, etc.). <br> b. name - This is the suffix used to form the full metric name. If `type` is `tag`, this column is instead considered as a tag which is applied to every metric collected by this particular query. |

Optionally use the `tags` parameter to apply a list of tags to each metric collected.
The **number of columns** Output from the Custom Query should be **equal to to number of metrics variables** in the conf.yaml file shown below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The **number of columns** Output from the Custom Query should be **equal to to number of metrics variables** in the conf.yaml file shown below.
The **number of columns** output from the Custom Query should be equal to to number of metrics variables in the `conf.yaml` file shown below.

@github-actions
Copy link

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@pierreln-dd pierreln-dd added the qa/skip-qa Automatically skip this PR for the next QA label Sep 23, 2025
@pierreln-dd
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 23, 2025

View all feedbacks in Devflow UI.

2025-09-23 07:46:34 UTC ℹ️ Start processing command /merge


2025-09-23 07:46:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-09-23 11:47:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@sethsamuel
Copy link
Contributor

Thanks for the contribution, the Oracle integration has moved to https://github.com/DataDog/datadog-agent/tree/main/pkg/collector/corechecks/oracle and this version is no longer maintained.

@sethsamuel sethsamuel closed this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants