Skip to content

[IDP-592] Add owner field to Network Device Monitoring Core integrations #21002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IDP-592] Add owner field to Network Device Monitoring Core integrations #21002

wants to merge 1 commit into from

Conversation

davidfeng-datadog
Copy link
Contributor

Add owner field set to "network-device-monitoring-core" to manifest.json files for Network Device Monitoring Core integrations (snmp, snmp_chatsworth_products, snmp_arista, snmp_juniper, snmp_netapp, snmp_cisco, snmp_f5, snmp_dell, snmp_fortinet, snmp_check_point, snmp_aruba, snmp_hewlett_packard_enterprise, snmp_american_power_conversion).

Note: These integrations are our best guesses for the Network Device Monitoring Core team. If you don't own these integrations, or if you also own other integrations that should be included, please let us know.

This provides clear ownership tracking for these SNMP-based network device monitoring integrations as part of the initiative to add owner fields to all integration manifest.json files.

For reviewer: Please confirm:

  1. Is "network-device-monitoring-core" the correct Datadog team slug in org 2 for tracking ownership?
  2. For the display-tile feature flags in SDP, what workday team should we use as the team tag? We believe it should be "Network Device Monitoring Core" - could you confirm this is the correct workday team name?

Thank you for your review!

🤖 Generated with Claude Code

@davidfeng-datadog davidfeng-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 11, 2025
@davidfeng-datadog davidfeng-datadog requested review from a team as code owners August 11, 2025 17:29
@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

17 similar comments
@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@github-actions GitHub Actions
Copy link

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent 
example/datadog_checks/__init__.py
example/datadog_checks/example/__about__.py
example/datadog_checks/example/__init__.py
example/datadog_checks/example/check.py
example/datadog_checks/example/config_models/__init__.py
example/datadog_checks/example/config_models/defaults.py
example/datadog_checks/example/config_models/instance.py
example/datadog_checks/example/config_models/shared.py
example/datadog_checks/example/config_models/validators.py
example/datadog_checks/example/data/conf.yaml.example
example/changelog.d/1.added
example/pyproject.toml
example/hatch.toml

@davidfeng-datadog davidfeng-datadog marked this pull request as draft August 11, 2025 17:31
@davidfeng-datadog davidfeng-datadog force-pushed the david.feng/IDP-592/add-owner-field-network-device-monitoring-core branch from 1693584 to 194eb53 Compare August 11, 2025 17:37
@davidfeng-datadog davidfeng-datadog changed the title Add owner field for Network Device Monitoring Core integrations (IDP-592) [IDP-592] Add owner field to Network Device Monitoring Core integrations Aug 11, 2025
@davidfeng-datadog @claude
[IDP-592] Add owner field to Network Device Monitoring Core integrations
32e2145 
Add `owner` field set to `"network-device-monitoring-core"` to manifest.json files for Network Device Monitoring Core integrations (snmp, snmp_chatsworth_products, snmp_arista, snmp_juniper, snmp_netapp, snmp_cisco, snmp_f5, snmp_dell, snmp_fortinet, snmp_check_point, snmp_aruba, snmp_hewlett_packard_enterprise, snmp_american_power_conversion).

**Note:** These integrations are our best guesses for the Network Device Monitoring Core team. If you don't own these integrations, or if you also own other integrations that should be included, please let us know.

This provides clear ownership tracking for these SNMP-based network device monitoring integrations as part of the initiative to add owner fields to all integration manifest.json files.

**For reviewer:** Please confirm:
1. Is `"network-device-monitoring-core"` the correct Datadog team slug in org 2 for tracking ownership?
2. For the display-tile feature flags in SDP, what workday team should we use as the `team` tag? We believe it should be "Network Device Monitoring Core" - could you confirm this is the correct workday team name?

Thank you for your review\!

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@davidfeng-datadog davidfeng-datadog force-pushed the david.feng/IDP-592/add-owner-field-network-device-monitoring-core branch from 194eb53 to 32e2145 Compare August 11, 2025 17:41
@davidfeng-datadog davidfeng-datadog marked this pull request as ready for review August 11, 2025 17:43
estherk15
estherk15 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

@Pierre-L42 Pierre-L42 Awaiting requested review from Pierre-L42 Pierre-L42 is a code owner automatically assigned from DataDog/ndm-core

Assignees
No one assigned
Labels
docs/approved documentation ecosystems/review-requested integration/active_directory integration/aspdotnet integration/checkpoint_quantum_firewall integration/dotnetclr integration/exchange_server integration/hyperv integration/iis integration/network_path integration/snmp_american_power_conversion integration/snmp_arista integration/snmp_aruba integration/snmp_chatsworth_products integration/snmp_check_point integration/snmp_cisco integration/snmp_dell integration/snmp_f5 integration/snmp_fortinet integration/snmp_hewlett_packard_enterprise integration/snmp_juniper integration/snmp_netapp integration/snmp integration/win32_event_log integration/wincrashdetect integration/windows_certificate integration/windows_performance_counters integration/windows_registry integration/windows_service integration/wmi_check product/review-requested qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation team/ndm-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfeng-datadog @estherk15